From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751378AbdAVQKh (ORCPT <rfc822;w@1wt.eu>);
        Sun, 22 Jan 2017 11:10:37 -0500
Received: from mail.skyhub.de ([78.46.96.112]:49630 "EHLO mail.skyhub.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750999AbdAVQKa (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 22 Jan 2017 11:10:30 -0500
Date: Sun, 22 Jan 2017 17:10:23 +0100
From: Borislav Petkov <bp@alien8.de>
To: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>, linux-edac@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] EDAC: always return an initialized value in
 knl_show_interleave_mode
Message-ID: <20170122161023.hmxbgiwse3f2qne6@pd.tnic>
References: <20170122135115.13256-1-nicolas.iooss_linux@m4x.org>
 <20170122144144.bwgkh3esdcveim3q@pd.tnic>
 <a3b9180e-2239-54db-6fb1-47577b994359@m4x.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <a3b9180e-2239-54db-6fb1-47577b994359@m4x.org>
User-Agent: NeoMutt/20161014 (1.7.1)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Jan 22, 2017 at 04:50:31PM +0100, Nicolas Iooss wrote:
>  	if (!is_knl)
>  		return interleave_mode(reg) ?
> 			"[8:6]" : "[8:6]XOR[18:16]";
>  	else
>  		return knl_intlv_mode[knl_interleave_mode(reg)];
> 
> Would this be good for you?

Ah, yes we interleave on address bits [8:6] when the bitield is 0 on KNL
while bitfield 0 for the rest of the families gives interleave mode for
the XOR of bits [8:6] and [18:16]. Good catch.

Thanks.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.