From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751766AbdAVUbJ (ORCPT ); Sun, 22 Jan 2017 15:31:09 -0500 Received: from mga01.intel.com ([192.55.52.88]:19279 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751047AbdAVUbE (ORCPT ); Sun, 22 Jan 2017 15:31:04 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,270,1477983600"; d="scan'208";a="1116289292" Date: Sun, 22 Jan 2017 22:30:55 +0200 From: Jarkko Sakkinen To: James Bottomley Cc: linux-security-module@vger.kernel.org, tpmdd-devel@lists.sourceforge.net, open list Subject: Re: [tpmdd-devel] [PATCH RFC v3 5/5] tpm2: expose resource manager via a device link /dev/tpms Message-ID: <20170122203055.zg52yraahqvn4rbv@intel.com> References: <20170116131215.28930-1-jarkko.sakkinen@linux.intel.com> <20170116131215.28930-6-jarkko.sakkinen@linux.intel.com> <1484751663.2717.10.camel@HansenPartnership.com> <20170119104922.vhgz4rxw6yzdrxqt@intel.com> <1484828380.3140.11.camel@HansenPartnership.com> <20170120133914.2wk43nteh2hh7n3c@intel.com> <20170120210522.glx4y4oui36oimld@intel.com> <1485107342.2504.7.camel@HansenPartnership.com> <1485110892.2504.12.camel@HansenPartnership.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1485110892.2504.12.camel@HansenPartnership.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 22, 2017 at 10:48:12AM -0800, James Bottomley wrote: > On Sun, 2017-01-22 at 09:49 -0800, James Bottomley wrote: > > On Fri, 2017-01-20 at 23:05 +0200, Jarkko Sakkinen wrote: > > > 'tabrm4' branch has been now rebased. It's now on top of master > > > branch that contains Stefan's latest patch (min body length check) > > > that I've reviewed and tested. It also contains your updated > > > /dev/tpms patch. > > > > > > I guess the 5 commits that are there now are such that we have > > > fairly good consensus, don't we? If so, can I add your reviewed-by > > > and tested-by to my commits and vice versa? > > > > We're still failing my test_transients. This is the full python of > > the test case: > > > > > > def test_transients(self): > > k = self.open_transients() > > self.c.flush_context(k[0]) > > self.c.change_auth(self.c.SRK, k[1], None, pwd1) > > ... > > > > It's failing at self.c.flush_context(k[0]) with TPM_RC_VALUE. It's > > the same problem Ken complained about: TPM2_FlushContext doesn't have > > a declared handle area so we don't translate the handle being sent > > down. We have to fix this either by intercepting the flush and > > manually translating the context, or by being dangerously clever and > > marking flush as a command which takes one handle. > > This is what the dangerously clever fix looks like. With this and a > few other changes, my smoke tests now pass. > > James I don't want to be clever here. I will rather intercept the body and try to keep the core code simple and easy to understand. /Jarkko