From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1750757AbdAWGUN (ORCPT <rfc822;w@1wt.eu>);
        Mon, 23 Jan 2017 01:20:13 -0500
Received: from mail-pf0-f196.google.com ([209.85.192.196]:34325 "EHLO
        mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750703AbdAWGUM (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 23 Jan 2017 01:20:12 -0500
Date: Mon, 23 Jan 2017 15:20:25 +0900
From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Minchan Kim <minchan@kernel.org>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
        Andrew Morton <akpm@linux-foundation.org>, zhouxianrong@huawei.com,
        linux-kernel@vger.kernel.org, sergey.senozhatsky@gmail.com
Subject: Re: [PATCH] zram: remove obsolete sysfs attrs
Message-ID: <20170123062025.GC2327@jagdpanzerIV.localdomain>
References: <20170118035838.11090-1-sergey.senozhatsky@gmail.com>
 <20170123060408.GB12327@bbox>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170123060408.GB12327@bbox>
User-Agent: Mutt/1.7.2 (2016-11-26)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On (01/23/17 15:04), Minchan Kim wrote:
> On Wed, Jan 18, 2017 at 12:58:38PM +0900, Sergey Senozhatsky wrote:
> > We had a deprecated_attr_warn() warning for 2 years and now the
> > time has come and we finally can do the cleanup.
> > 
> > The plan was as follows:
> > 
> > : per-stat sysfs attributes are considered to be deprecated.
> > : The basic strategy is:
> > : -- the existing RW nodes will be downgraded to WO nodes (in linux 4.11)
> > : -- deprecated RO sysfs nodes will eventually be removed (in linux 4.11)
> > :
> > : The list of deprecated attributes can be found here:
> > : Documentation/ABI/obsolete/sysfs-block-zram
> > :
> > : Basically, every attribute that has its own read accessible sysfs
> > : node (e.g. num_reads) *AND* is accessible via one of the stat files
> > : (zram<id>/stat or zram<id>/io_stat or zram<id>/mm_stat) is considered
> > : to be deprecated.
> > 
> > The patch also removes `obsolete/sysfs-block-zram', clean ups
> > `testing/sysfs-block-zram' and tweaks zram.txt files.
> > 
> > Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> Acked-by: Minchan Kim <minchan@kernel.org>

thanks.


I didn't touch some of the attrs. we can start a new deprecation cycle
a bit later. for instance, our sysfs zram_hot add/remove must leave; and
max_comp_streams is still RW - we left if intact just in case if we would
revert per-cpu compression stream and return idle list back.

	-ss