From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750814AbdAWIs6 (ORCPT ); Mon, 23 Jan 2017 03:48:58 -0500 Received: from mx1.redhat.com ([209.132.183.28]:58666 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750703AbdAWIs5 (ORCPT ); Mon, 23 Jan 2017 03:48:57 -0500 Date: Mon, 23 Jan 2017 16:48:50 +0800 From: Dave Young To: Xunlei Pang Cc: linux-kernel@vger.kernel.org, kexec@lists.infradead.org, x86@kernel.org, Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Thomas Gleixner , Andrew Morton , Robert LeBlanc , Baoquan He Subject: Re: [PATCH v2] x86/crash: Update the stale comment in reserve_crashkernel() Message-ID: <20170123084850.GA15988@dhcp-128-65.nay.redhat.com> References: <1485154103-18426-1-git-send-email-xlpang@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1485154103-18426-1-git-send-email-xlpang@redhat.com> User-Agent: Mutt/1.7.1 (2016-10-04) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Mon, 23 Jan 2017 08:48:58 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Xunlei On 01/23/17 at 02:48pm, Xunlei Pang wrote: > CRASH_KERNEL_ADDR_MAX has been missing for a long time, > update it with more detailed explanation. > > Cc: Robert LeBlanc > Cc: Baoquan He > Signed-off-by: Xunlei Pang > --- > arch/x86/kernel/setup.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c > index 4cfba94..c32a167 100644 > --- a/arch/x86/kernel/setup.c > +++ b/arch/x86/kernel/setup.c > @@ -575,7 +575,9 @@ static void __init reserve_crashkernel(void) > /* 0 means: find the address automatically */ > if (crash_base <= 0) { > /* > - * kexec want bzImage is below CRASH_KERNEL_ADDR_MAX > + * Set CRASH_ADDR_LOW_MAX upper bound for crash memory > + * as old kexec-tools loads bzImage below that, unless > + * "crashkernel=size[KMG],high" is specified. There is already comment before the define of those macros, also there are 32bit case which has a different reason about 512M there as well. So it looks better to just drop the one line comment without adding further comments here. > */ > crash_base = memblock_find_in_range(CRASH_ALIGN, > high ? CRASH_ADDR_HIGH_MAX > -- > 1.8.3.1 > Thanks Dave