From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750890AbdAWJEx (ORCPT ); Mon, 23 Jan 2017 04:04:53 -0500 Received: from mail-pf0-f195.google.com ([209.85.192.195]:34451 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750714AbdAWJEv (ORCPT ); Mon, 23 Jan 2017 04:04:51 -0500 Date: Mon, 23 Jan 2017 17:04:28 +0800 From: Peter Chen To: Jisheng Zhang Cc: Peter.Chen@nxp.com, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [RESEND PATCH] usb: chipidea: usb2: delete the redundant setting default DMA mask code Message-ID: <20170123090428.GB19373@b29397-desktop> References: <20170123070923.2770-1-jszhang@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170123070923.2770-1-jszhang@marvell.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 23, 2017 at 03:09:23PM +0800, Jisheng Zhang wrote: > Similar as commit 2b2fe36def08 ("usb: chipidea: imx: delete the > redundant setting default DMA mask code"), the ci_hdrc_usb2 platform > device is also created by device tree, the default DMA mask should be > already set by of_dma_configure when the device are created. So delete > the redundant code at driver. > > Signed-off-by: Jisheng Zhang > --- > drivers/usb/chipidea/ci_hdrc_usb2.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/usb/chipidea/ci_hdrc_usb2.c b/drivers/usb/chipidea/ci_hdrc_usb2.c > index 4456d2cf80ff..d162cc0bb8ce 100644 > --- a/drivers/usb/chipidea/ci_hdrc_usb2.c > +++ b/drivers/usb/chipidea/ci_hdrc_usb2.c > @@ -74,10 +74,6 @@ static int ci_hdrc_usb2_probe(struct platform_device *pdev) > } > } > > - ret = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(32)); > - if (ret) > - goto clk_err; > - > ci_pdata->name = dev_name(dev); > > priv->ci_pdev = ci_hdrc_add_device(dev, pdev->resource, Applied, thanks. -- Best Regards, Peter Chen