From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751091AbdAWMEd (ORCPT ); Mon, 23 Jan 2017 07:04:33 -0500 Received: from mail.skyhub.de ([78.46.96.112]:51222 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750738AbdAWMEc (ORCPT ); Mon, 23 Jan 2017 07:04:32 -0500 Date: Mon, 23 Jan 2017 13:04:25 +0100 From: Borislav Petkov To: Nicolas Iooss Cc: Mauro Carvalho Chehab , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/1] EDAC: kill ->show_interleave_mode() Message-ID: <20170123120424.u24fclewbfdznf7n@pd.tnic> References: <20170122172806.10412-1-nicolas.iooss_linux@m4x.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170122172806.10412-1-nicolas.iooss_linux@m4x.org> User-Agent: NeoMutt/20161014 (1.7.1) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 22, 2017 at 06:28:06PM +0100, Nicolas Iooss wrote: > Function sbridge_register_mci() sets pvt->info.show_interleave_mode to > knl_show_interleave_mode() on Knight's Landing and > show_interleave_mode() anywhere else. These functions are only called in > a debug statement and knl_show_interleave_mode() implementation causes a > compiler warning (the compiler fails to understand that the default > branch of the switch condition can never be reached because reg is a > 2-bit value). > > Merge show_interleave_mode() and knl_show_interleave_mode() in a single > implementation and use it without an indirect function pointer. > > Signed-off-by: Nicolas Iooss > --- > drivers/edac/sb_edac.c | 44 ++++++++++---------------------------------- > 1 file changed, 10 insertions(+), 34 deletions(-) Applied, thanks. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.