From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751067AbdAWN6A (ORCPT <rfc822;w@1wt.eu>);
        Mon, 23 Jan 2017 08:58:00 -0500
Received: from mail-pg0-f65.google.com ([74.125.83.65]:35155 "EHLO
        mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750703AbdAWN57 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 23 Jan 2017 08:57:59 -0500
Date: Mon, 23 Jan 2017 22:57:24 +0900
From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To: Minchan Kim <minchan@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] zram: remove waitqueue for IO done
Message-ID: <20170123135724.GA438@tigerII.localdomain>
References: <1485145031-11661-1-git-send-email-minchan@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1485145031-11661-1-git-send-email-minchan@kernel.org>
User-Agent: Mutt/1.7.2 (2016-11-26)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On (01/23/17 13:17), Minchan Kim wrote:
> zram_reset_device waits ongoing writepage pages completed by
> zram->refcount logic. However, it's pointless because before
> the reset, we prevent further opening of zram by zram->claim
> and flush all of pending IO by fsync_bdev so there should be
> no pending IO at the zram_reset_device.

interesting.
looks reasonable to me.

> Signed-off-by: Minchan Kim <minchan@kernel.org>

Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>

	-ss