From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751106AbdAWPNp (ORCPT <rfc822;w@1wt.eu>);
        Mon, 23 Jan 2017 10:13:45 -0500
Received: from vps0.lunn.ch ([178.209.37.122]:41685 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750997AbdAWPNo (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 23 Jan 2017 10:13:44 -0500
Date: Mon, 23 Jan 2017 16:13:42 +0100
From: Andrew Lunn <andrew@lunn.ch>
To: Valentin Rothberg <valentinrothberg@gmail.com>
Cc: davem@davemloft.net, LKML <linux-kernel@vger.kernel.org>
Subject: Re: net: dsa: remaining references on NET_DSA_HWMON
Message-ID: <20170123151342.GF10895@lunn.ch>
References: <878e828d-1409-d2b5-1606-9c3a6f299095@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <878e828d-1409-d2b5-1606-9c3a6f299095@gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jan 23, 2017 at 10:31:12AM +0100, Valentin Rothberg wrote:
> Hi Andrew,
> 
> your commit cf1a56a4cf19 ("net: dsa: Remove hwmon support") has popped
> up in today's linux-next.  The commit removes all references on
> NET_DSA_HWMON but the following:
> 
> Documentation/networking/dsa/dsa.txt:501:These callbacks are only
> available if CONFIG_NET_DSA_HWMON is enabled:
> 
> include/net/dsa.h:181:#ifdef CONFIG_NET_DSA_HWMON
> 
> Is it on purpose?

Hi Valentin

Nope, those should be cleaned up as well.

Thanks for pointing this out.

       Andrew