From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751370AbdAWREN (ORCPT ); Mon, 23 Jan 2017 12:04:13 -0500 Received: from mail-oi0-f67.google.com ([209.85.218.67]:34607 "EHLO mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750732AbdAWREM (ORCPT ); Mon, 23 Jan 2017 12:04:12 -0500 Date: Mon, 23 Jan 2017 11:04:09 -0600 From: Rob Herring To: Matt Ranostay Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, ulf.hansson@linaro.org, devicetree@vger.kernel.org Subject: Re: [PATCH v3 1/2] devicetree: document new marvell-8xxx and pwrseq-sd8787 options Message-ID: <20170123170409.rnmnf4ssjpd2yk3l@rob-hp-laptop> References: <20170121055039.10924-1-matt@ranostay.consulting> <20170121055039.10924-2-matt@ranostay.consulting> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170121055039.10924-2-matt@ranostay.consulting> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 20, 2017 at 09:50:38PM -0800, Matt Ranostay wrote: > Cc: devicetree@vger.kernel.org > Signed-off-by: Matt Ranostay > --- > .../devicetree/bindings/mmc/mmc-pwrseq-sd8787.txt | 14 ++++++++++++++ > .../devicetree/bindings/net/wireless/marvell-8xxx.txt | 7 ++++++- > 2 files changed, 20 insertions(+), 1 deletion(-) > create mode 100644 Documentation/devicetree/bindings/mmc/mmc-pwrseq-sd8787.txt > > diff --git a/Documentation/devicetree/bindings/mmc/mmc-pwrseq-sd8787.txt b/Documentation/devicetree/bindings/mmc/mmc-pwrseq-sd8787.txt > new file mode 100644 > index 000000000000..4bb56766982e > --- /dev/null > +++ b/Documentation/devicetree/bindings/mmc/mmc-pwrseq-sd8787.txt > @@ -0,0 +1,14 @@ > +* Marvell SD8787 power sequence provider > + > +Required properties: > +- compatible: must be "mmc-pwrseq-sd8787". > +- powerdown-gpio: contains a power down GPIO specifier with active state > +- reset-gpio: contains a reset GPIO specifier with active state My comments on the previous v3 still apply. > + > +Example: > + > + wifi_pwrseq: wifi_pwrseq { > + compatible = "mmc-pwrseq-sd8787"; > + powerdown-gpio = <&twl_gpio 0 GPIO_ACTIVE_LOW>; > + reset-gpio = <&twl_gpio 1 GPIO_ACTIVE_LOW>; > + }