From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751524AbdAWSKi (ORCPT ); Mon, 23 Jan 2017 13:10:38 -0500 Received: from vps0.lunn.ch ([178.209.37.122]:41896 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750742AbdAWSKh (ORCPT ); Mon, 23 Jan 2017 13:10:37 -0500 Date: Mon, 23 Jan 2017 19:10:34 +0100 From: Andrew Lunn To: Jisheng Zhang Cc: thomas.petazzoni@free-electrons.com, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jingju Hou Subject: Re: [PATCH v4 net-next] net: mvneta: implement .set_wol and .get_wol Message-ID: <20170123181034.GN10895@lunn.ch> References: <20170123065507.2557-1-jszhang@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170123065507.2557-1-jszhang@marvell.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 23, 2017 at 02:55:07PM +0800, Jisheng Zhang wrote: > From: Jingju Hou > > From: Jingju Hou > > The mvneta itself does not support WOL, but the PHY might. > So pass the calls to the PHY > > Signed-off-by: Jingju Hou > Signed-off-by: Jisheng Zhang > --- > since v3: > - really fix the build error Keep trying.... But maybe tomorrow, after you have taken the pause Dave said you should take, and maybe ask Jingju to really review it, in detail. > > since v2,v1: > - using phy_dev member in struct net_device > - add commit msg > > drivers/net/ethernet/marvell/mvneta.c | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c > index 6dcc951af0ff..02611fa1c3b8 100644 > --- a/drivers/net/ethernet/marvell/mvneta.c > +++ b/drivers/net/ethernet/marvell/mvneta.c > @@ -3929,6 +3929,25 @@ static int mvneta_ethtool_get_rxfh(struct net_device *dev, u32 *indir, u8 *key, > return 0; > } > > +static void mvneta_ethtool_get_wol(struct net_device *dev, > + struct ethtool_wolinfo *wol) > +{ > + wol->supported = 0; > + wol->wolopts = 0; > + > + if (dev->phydev) > + return phy_ethtool_get_wol(dev->phydev, wol); This is a void function. And you are returning a value. And phy_ethtool_get_wol() is also a void function, so does not actually return anything. 0-day was telling you this. Please read what is said. Andrew