From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750914AbdAXRl2 convert rfc822-to-8bit (ORCPT ); Tue, 24 Jan 2017 12:41:28 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:51758 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750764AbdAXRl0 (ORCPT ); Tue, 24 Jan 2017 12:41:26 -0500 Date: Tue, 24 Jan 2017 12:41:19 -0500 (EST) Message-Id: <20170124.124119.2246238373876916746.davem@davemloft.net> To: linus.luessing@c0d3.blue Cc: netdev@vger.kernel.org, stephen@networkplumber.org, nbd@nbd.name, nikolay@cumulusnetworks.com, bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org Subject: Re: [PATCH net-next v5] bridge: multicast to unicast From: David Miller In-Reply-To: <20170121200133.1864-1-linus.luessing@c0d3.blue> References: <20170121200133.1864-1-linus.luessing@c0d3.blue> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 24 Jan 2017 08:42:17 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Linus Lüssing Date: Sat, 21 Jan 2017 21:01:32 +0100 > From: Felix Fietkau > > Implements an optional, per bridge port flag and feature to deliver > multicast packets to any host on the according port via unicast > individually. This is done by copying the packet per host and > changing the multicast destination MAC to a unicast one accordingly. > > multicast-to-unicast works on top of the multicast snooping feature of > the bridge. Which means unicast copies are only delivered to hosts which > are interested in it and signalized this via IGMP/MLD reports > previously. > > This feature is intended for interface types which have a more reliable > and/or efficient way to deliver unicast packets than broadcast ones > (e.g. wifi). > > However, it should only be enabled on interfaces where no IGMPv2/MLDv1 > report suppression takes place. This feature is disabled by default. > > The initial patch and idea is from Felix Fietkau. > > Signed-off-by: Felix Fietkau > [linus.luessing@c0d3.blue: various bug + style fixes, commit message] > Signed-off-by: Linus Lüssing I'm not completely happy that things have progressed this way, however I don't have a better solution to suggest.