From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750985AbdAXTJ2 (ORCPT ); Tue, 24 Jan 2017 14:09:28 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:55632 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750951AbdAXTJ0 (ORCPT ); Tue, 24 Jan 2017 14:09:26 -0500 Date: Tue, 24 Jan 2017 14:09:24 -0500 (EST) Message-Id: <20170124.140924.1432554530568021817.davem@davemloft.net> To: arnd@arndb.de Cc: f.fainelli@gmail.com, andrew@lunn.ch, charles-antoine.couret@nexvision.fr, clemens.gruber@pqgruber.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] phy: marvell: remove conflicting initializer From: David Miller In-Reply-To: <20170123121905.3245589-1-arnd@arndb.de> References: <20170123121905.3245589-1-arnd@arndb.de> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 24 Jan 2017 10:10:22 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann Date: Mon, 23 Jan 2017 13:18:41 +0100 > One line was apparently pasted incorrectly during a new feature patch: > > drivers/net/phy/marvell.c:2090:15: error: initialized field overwritten [-Werror=override-init] > .features = PHY_GBIT_FEATURES, > > I'm removing the extraneous line here to avoid the W=1 warning and restore > the previous flags value, and I'm slightly reordering the lines for consistency > to make it less likely to happen again in the future. The ordering in the > array is still not the same as in the structure definition, instead I picked > the order that is most common in this file and that seems to make more sense > here. > > Fixes: 0b04680fdae4 ("phy: marvell: Add support for temperature sensor") > Signed-off-by: Arnd Bergmann Applied, thanks Arnd. Please start putting appropriate "net" and "net-next" strings in your PATCH subject lines, it will save me a lot of time.