From: David Miller <davem@davemloft.net>
To: mst@redhat.com
Cc: linux-kernel@vger.kernel.org, jasowang@redhat.com,
virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, john.fastabend@gmail.com
Subject: Re: [PATCH v2] virtio_net: fix PAGE_SIZE > 64k
Date: Tue, 24 Jan 2017 14:42:27 -0500 (EST) [thread overview]
Message-ID: <20170124.144227.2017106704873029028.davem@davemloft.net> (raw)
In-Reply-To: <1485197869-11350-1-git-send-email-mst@redhat.com>
From: "Michael S. Tsirkin" <mst@redhat.com>
Date: Mon, 23 Jan 2017 21:37:52 +0200
> I don't have any guests with PAGE_SIZE > 64k but the
> code seems to be clearly broken in that case
> as PAGE_SIZE / MERGEABLE_BUFFER_ALIGN will need
> more than 8 bit and so the code in mergeable_ctx_to_buf_address
> does not give us the actual true size.
>
> Cc: John Fastabend <john.fastabend@gmail.com>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Applied, thanks Michael.
I am really trying to be patient, but we are about to run out of
time for fixing the adjust header XDP stuff.
That should have been resolved in a week or two, but now we're
basically a month or so later.
Please come to some kind of agreement about how to implement this
because we can't let v4.10 go out without this being resolved.
Thank you.
next prev parent reply other threads:[~2017-01-24 19:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-23 19:37 Michael S. Tsirkin
2017-01-24 19:42 ` David Miller [this message]
2017-01-24 19:53 ` Michael S. Tsirkin
2017-01-24 20:09 ` David Miller
2017-01-24 20:45 ` Michael S. Tsirkin
2017-01-24 20:53 ` David Miller
2017-01-24 21:07 ` Michael S. Tsirkin
2017-01-24 21:10 ` David Miller
2017-01-24 21:56 ` Michael S. Tsirkin
2017-01-25 3:48 ` John Fastabend
2017-01-25 4:07 Alexei Starovoitov
2017-01-25 14:23 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170124.144227.2017106704873029028.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jasowang@redhat.com \
--cc=john.fastabend@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®