From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750925AbdAXUAo (ORCPT ); Tue, 24 Jan 2017 15:00:44 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:57878 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750896AbdAXUAm (ORCPT ); Tue, 24 Jan 2017 15:00:42 -0500 Date: Tue, 24 Jan 2017 15:00:40 -0500 (EST) Message-Id: <20170124.150040.1773076921308385136.davem@davemloft.net> To: f.fainelli@gmail.com Cc: netdev@vger.kernel.org, andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] net: dsa: Drop WARN() in tag_brcm.c From: David Miller In-Reply-To: <20170124031907.28328-1-f.fainelli@gmail.com> References: <20170124031907.28328-1-f.fainelli@gmail.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 24 Jan 2017 11:01:38 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Florian Fainelli Date: Mon, 23 Jan 2017 19:19:07 -0800 > We may be able to see invalid Broadcom tags when the hardware and drivers are > misconfigured, or just while exercising the error path. Instead of flooding > the console with messages, flat out drop the packet. > > Signed-off-by: Florian Fainelli Applied.