From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1750916AbdAXLsO (ORCPT <rfc822;w@1wt.eu>);
        Tue, 24 Jan 2017 06:48:14 -0500
Received: from 2.mo69.mail-out.ovh.net ([178.33.251.80]:32898 "EHLO
        2.mo69.mail-out.ovh.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750812AbdAXLsN (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 24 Jan 2017 06:48:13 -0500
Date: Tue, 24 Jan 2017 12:48:05 +0100
From: Greg Kurz <groug@kaod.org>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
        Frederic Barrat <fbarrat@linux.vnet.ibm.com>,
        Ian Munsie <imunsie@au1.ibm.com>
Subject: Re: [PATCH] cxl: drop unused header asm/pnv-pci.h
Message-ID: <20170124124805.6b8e798f@bahia.lan>
In-Reply-To: <87k29kaih9.fsf@concordia.ellerman.id.au>
References: <148482301037.30441.14177888563610790803.stgit@bahia>
        <87k29kaih9.fsf@concordia.ellerman.id.au>
X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-Ovh-Tracer-Id: 4538221050978605489
X-VR-SPAMSTATE: OK
X-VR-SPAMSCORE: -100
X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrfeelgedrhedugdeffecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 24 Jan 2017 20:57:06 +1100
Michael Ellerman <mpe@ellerman.id.au> wrote:

> Greg Kurz <groug@kaod.org> writes:
> 
> > The kernel API does not use anything from this header file.  
> 
> That's actually hard to prove in general, because pnv-pci.h includes
> linux/pci.h, linux/pci_hotplug.h, linux/irq.h, misc/cxl-base.h and
> asm/opal-api.h. At least four of which aren't included directly by
> api.c.
> 
> But I'll take you word for it :)
> 

Sorry for the lack of details...

api.c doesn't do anything related to pci hotplug, nor to OPAL. This
happens in pci.c.

It includes cxl.h which includes misc/cxl-base.h.

The only generic irq bits are irq_hw_number_t, provided by linux/types.h,
and irq_find_mapping(), provided by linux/irqdomain.h, which is included
by misc/cxl-base.h -> linux/interrupt.h -> asm/irq.h.

Cheers (and congrats :)

--
Greg


> cheers
> 
> > diff --git a/drivers/misc/cxl/api.c b/drivers/misc/cxl/api.c
> > index 1b35e33d2434..bcc030eacab7 100644
> > --- a/drivers/misc/cxl/api.c
> > +++ b/drivers/misc/cxl/api.c
> > @@ -11,7 +11,6 @@
> >  #include <linux/slab.h>
> >  #include <linux/file.h>
> >  #include <misc/cxl.h>
> > -#include <asm/pnv-pci.h>
> >  #include <linux/msi.h>
> >  #include <linux/module.h>
> >  #include <linux/mount.h>