From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750971AbdAXWTf (ORCPT ); Tue, 24 Jan 2017 17:19:35 -0500 Received: from bh-25.webhostbox.net ([208.91.199.152]:45777 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750788AbdAXWTd (ORCPT ); Tue, 24 Jan 2017 17:19:33 -0500 Date: Tue, 24 Jan 2017 14:19:29 -0800 From: Guenter Roeck To: William Breathitt Gray Cc: wim@iguana.be, linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] watchdog: ebc-c384_wdt: Utilize devm_ functions in driver probe callback Message-ID: <20170124221929.GA11399@roeck-us.net> References: <20170124220233.3389-1-vilhelm.gray@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170124220233.3389-1-vilhelm.gray@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: guenter@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 24, 2017 at 05:02:33PM -0500, William Breathitt Gray wrote: > The devm_ resource manager functions allow memory to be automatically > released when a device is unbound. This patch takes advantage of the > resource manager functions and replaces the watchdog_register_device > call with the devm_watchdog_register_device call. In addition, the > ebc_c384_wdt_remove function has been removed as no longer necessary due > to the use of the relevant devm_ resource manager functions. > > Signed-off-by: William Breathitt Gray Reviewed-by: Guenter Roeck > --- > Changes in v2: > - Removed dev_set_drvdata call in ebc_c384_wdt_probe; now that > ebc_c384_wdt_remove is gone, the driver_data doesn't need to be set > > drivers/watchdog/ebc-c384_wdt.c | 14 +------------- > 1 file changed, 1 insertion(+), 13 deletions(-) > > diff --git a/drivers/watchdog/ebc-c384_wdt.c b/drivers/watchdog/ebc-c384_wdt.c > index 4b849b8e..2170b275 100644 > --- a/drivers/watchdog/ebc-c384_wdt.c > +++ b/drivers/watchdog/ebc-c384_wdt.c > @@ -121,18 +121,7 @@ static int ebc_c384_wdt_probe(struct device *dev, unsigned int id) > dev_warn(dev, "Invalid timeout (%u seconds), using default (%u seconds)\n", > timeout, WATCHDOG_TIMEOUT); > > - dev_set_drvdata(dev, wdd); > - > - return watchdog_register_device(wdd); > -} > - > -static int ebc_c384_wdt_remove(struct device *dev, unsigned int id) > -{ > - struct watchdog_device *wdd = dev_get_drvdata(dev); > - > - watchdog_unregister_device(wdd); > - > - return 0; > + return devm_watchdog_register_device(dev, wdd); > } > > static struct isa_driver ebc_c384_wdt_driver = { > @@ -140,7 +129,6 @@ static struct isa_driver ebc_c384_wdt_driver = { > .driver = { > .name = MODULE_NAME > }, > - .remove = ebc_c384_wdt_remove > }; > > static int __init ebc_c384_wdt_init(void) > -- > 2.11.0 >