From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752038AbdAYRew (ORCPT ); Wed, 25 Jan 2017 12:34:52 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:55338 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751589AbdAYRev (ORCPT ); Wed, 25 Jan 2017 12:34:51 -0500 Date: Wed, 25 Jan 2017 12:34:48 -0500 (EST) Message-Id: <20170125.123448.742815192519658537.davem@davemloft.net> To: green.hu@gmail.com Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, andrew@lunn.ch, arnd@arndb.de, jiri@resnulli.us, linux-kernel@vger.kernel.org, f.fainelli@gmail.com, robh+dt@kernel.org, mark.rutland@arm.com Subject: Re: [PATCH v4] net: ethernet: faraday: To support device tree usage. From: David Miller In-Reply-To: <20170124084606.GA11764@app09> References: <20170124084606.GA11764@app09> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 25 Jan 2017 08:35:46 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Greentime Hu Date: Tue, 24 Jan 2017 16:46:14 +0800 > We also use the same binding document to describe the same faraday ethernet > controller and add faraday to vendor-prefixes.txt. > > Signed-off-by: Greentime Hu > --- > Changes in v4: > - Use the same binding document to describe the same faraday ethernet controller and add faraday to vendor-prefixes.txt. > Changes in v3: > - Nothing changed in this patch but I have committed andestech to vendor-prefixes.txt. > Changes in v2: > - Change atmac100_of_ids to ftmac100_of_ids > > --- > .../net/{moxa,moxart-mac.txt => faraday,ftmac.txt} | 7 +++++-- > .../devicetree/bindings/vendor-prefixes.txt | 1 + > drivers/net/ethernet/faraday/ftmac100.c | 7 +++++++ > 3 files changed, 13 insertions(+), 2 deletions(-) > rename Documentation/devicetree/bindings/net/{moxa,moxart-mac.txt => faraday,ftmac.txt} (68%) > > diff --git a/Documentation/devicetree/bindings/net/moxa,moxart-mac.txt b/Documentation/devicetree/bindings/net/faraday,ftmac.txt > similarity index 68% > rename from Documentation/devicetree/bindings/net/moxa,moxart-mac.txt > rename to Documentation/devicetree/bindings/net/faraday,ftmac.txt Why are you renaming the MOXA binding file instead of adding a completely new one for faraday? The MOXA one should stick around, I don't see a justification for removing it.