From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751939AbdAYTsP (ORCPT ); Wed, 25 Jan 2017 14:48:15 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:33620 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751513AbdAYTsO (ORCPT ); Wed, 25 Jan 2017 14:48:14 -0500 Date: Wed, 25 Jan 2017 14:48:12 -0500 (EST) Message-Id: <20170125.144812.1720429757967902440.davem@davemloft.net> To: f.fainelli@gmail.com Cc: netdev@vger.kernel.org, andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] net: dsa: Bring back device detaching in dsa_slave_suspend() From: David Miller In-Reply-To: <20170125171041.21442-1-f.fainelli@gmail.com> References: <20170125171041.21442-1-f.fainelli@gmail.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 25 Jan 2017 10:49:10 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Florian Fainelli Date: Wed, 25 Jan 2017 09:10:41 -0800 > Commit 448b4482c671 ("net: dsa: Add lockdep class to tx queues to avoid > lockdep splat") removed the netif_device_detach() call done in > dsa_slave_suspend() which is necessary, and paired with a corresponding > netif_device_attach(), bring it back. > > Fixes: 448b4482c671 ("net: dsa: Add lockdep class to tx queues to avoid lockdep splat") > Signed-off-by: Florian Fainelli > --- > David, > > Can you also queue this for -stable? Thanks! Applied and queued up for -stable, thanks.