From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752461AbdAYWNe (ORCPT <rfc822;w@1wt.eu>);
        Wed, 25 Jan 2017 17:13:34 -0500
Received: from shards.monkeyblade.net ([184.105.139.130]:40112 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751781AbdAYWNc (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 25 Jan 2017 17:13:32 -0500
Date: Wed, 25 Jan 2017 17:13:28 -0500 (EST)
Message-Id: <20170125.171328.1978684823149751445.davem@davemloft.net>
To: rob.gardner@oracle.com
Cc: khalid.aziz@oracle.com, corbet@lwn.net, viro@zeniv.linux.org.uk,
        nitin.m.gupta@oracle.com, mike.kravetz@oracle.com,
        akpm@linux-foundation.org, mingo@kernel.org,
        kirill.shutemov@linux.intel.com, adam.buchbinder@gmail.com,
        hughd@google.com, minchan@kernel.org, keescook@chromium.org,
        chris.hyser@oracle.com, atish.patra@oracle.com, cmetcalf@mellanox.com,
        atomlin@redhat.com, jslaby@suse.cz, joe@perches.com,
        paul.gortmaker@windriver.com, mhocko@suse.com, lstoakes@gmail.com,
        jack@suse.cz, dave.hansen@linux.intel.com, vbabka@suse.cz,
        dan.j.williams@intel.com, iamjoonsoo.kim@lge.com,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        sparclinux@vger.kernel.org, linux-mm@kvack.org, khalid@gonehiking.org
Subject: Re: [PATCH v5 4/4] sparc64: Add support for ADI (Application Data
 Integrity)
From: David Miller <davem@davemloft.net>
In-Reply-To: <154bc417-6333-f9ac-653b-9ed280f08450@oracle.com>
References: <cover.1485362562.git.khalid.aziz@oracle.com>
        <0b6865aabc010ee3a7ea956a70447abbab53ea70.1485362562.git.khalid.aziz@oracle.com>
        <154bc417-6333-f9ac-653b-9ed280f08450@oracle.com>
X-Mailer: Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 25 Jan 2017 13:14:28 -0800 (PST)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Rob Gardner <rob.gardner@oracle.com>
Date: Wed, 25 Jan 2017 15:00:42 -0700

> Same comment here, and the various other places that employ this same
> code construct.

Please do not quote an entire huge patch just to comment on a small
part of it.

Quote only the minimum necessary context in order to provide your feedback.

Thank you.