From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752173AbdAYOVs (ORCPT ); Wed, 25 Jan 2017 09:21:48 -0500 Received: from mx2.suse.de ([195.135.220.15]:38881 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751803AbdAYOVr (ORCPT ); Wed, 25 Jan 2017 09:21:47 -0500 Date: Wed, 25 Jan 2017 15:21:42 +0100 From: Michal Hocko To: Tetsuo Handa Cc: akpm@linux-foundation.org, mgorman@suse.de, hannes@cmpxchg.org, vdavydov.dev@gmail.com, pmladek@suse.com, sergey.senozhatsky.work@gmail.com, vegard.nossum@oracle.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6] mm: Add memory allocation watchdog kernel thread. Message-ID: <20170125142141.GT32377@dhcp22.suse.cz> References: <1478416501-10104-1-git-send-email-penguin-kernel@I-love.SAKURA.ne.jp> <201612151924.HJJ69799.VSFLHOQFFMOtOJ@I-love.SAKURA.ne.jp> <201612282042.GDB17129.tOHFOFSQOFLVJM@I-love.SAKURA.ne.jp> <201701252303.FCI17866.FOJFHMtSQOFVLO@I-love.SAKURA.ne.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201701252303.FCI17866.FOJFHMtSQOFVLO@I-love.SAKURA.ne.jp> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 25-01-17 23:03:43, Tetsuo Handa wrote: > Andrew, what do you think about this version? There seems to be no objections. Well, this is not true. My main objection still holds. I simply do not think all the additional code is really worth it. Not enough to nack the patch, though, of course. I am not questioning that the watchdog might be useful for debugging. I just think that what we have currently tells us enough to debug issues. Sure, you will tell that this is not reliable, but I will argue that this should be fixed because that makes sense regardless of the stall warning. -- Michal Hocko SUSE Labs