mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Alexander Potapenko <glider@google.com>
Cc: Andrey Ryabinin <aryabinin@virtuozzo.com>,
	Dmitry Vyukov <dvyukov@google.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH] kasan: Respect /proc/sys/kernel/traceoff_on_warning
Date: Wed, 25 Jan 2017 15:35:32 +0100	[thread overview]
Message-ID: <20170125143532.GR6515@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <CAG_fn=VyWy1GHGyncasKNKrq8n1LZhVutX7_m83cMXAbLVUoDQ@mail.gmail.com>

On Wed, Jan 25, 2017 at 03:32:11PM +0100, Alexander Potapenko wrote:

> > @@ -300,6 +301,8 @@ void kasan_report(unsigned long addr, size_t size,
> >         if (likely(!kasan_report_enabled()))
> >                 return;
> >
> > +       disable_trace_on_warning();
> > +
> Who is going to enable tracing back after we're done?

The user..

> Note that KASAN errors are not fatal, and the first one may possibly
> occur quite early.

WARN*() isn't fatal either, and it does the same thing. Note that
traceoff_on_warning is default disabled. You have to explicitly request
this.

  reply	other threads:[~2017-01-25 14:35 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-25 14:25 Peter Zijlstra
2017-01-25 14:28 ` Peter Zijlstra
2017-01-25 14:32   ` Alexander Potapenko
2017-01-25 14:35     ` Peter Zijlstra [this message]
2017-01-25 14:37       ` Alexander Potapenko
2017-01-30 19:18       ` Steven Rostedt
2017-01-25 14:38 ` Alexander Potapenko
2017-01-25 15:29 ` kbuild test robot
2017-01-25 16:41 ` [PATCH v2] " Andrey Ryabinin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170125143532.GR6515@twins.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=aryabinin@virtuozzo.com \
    --cc=dvyukov@google.com \
    --cc=glider@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome