From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750921AbdAYOmB (ORCPT ); Wed, 25 Jan 2017 09:42:01 -0500 Received: from bombadil.infradead.org ([65.50.211.133]:37542 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750746AbdAYOmA (ORCPT ); Wed, 25 Jan 2017 09:42:00 -0500 Date: Wed, 25 Jan 2017 06:41:49 -0800 From: Matthew Wilcox To: Jinbum Park Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, keescook@chromium.org, arjan@linux.intel.com, akpm@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, labbott@redhat.com, kernel-hardening@lists.openwall.com, mark.rutland@arm.com, kernel-janitors@vger.kernel.org, linux@armlinux.org.uk Subject: Re: [PATCH v4] mm: add arch-independent testcases for RODATA Message-ID: <20170125144149.GA970@bombadil.infradead.org> References: <20170125141833.GA27658@pjb1027-Latitude-E5410> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170125141833.GA27658@pjb1027-Latitude-E5410> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 25, 2017 at 11:18:33PM +0900, Jinbum Park wrote: > + /* test 2: write to the variable; this should fault */ > + /* > + * This must be written in assembly to be able to catch the > + * exception that is supposed to happen in the correct case. > + * > + * So that probe_kernel_write is used to write > + * arch-independent assembly. > + */ This comment makes no sense. Better to just delete the comment.