From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751944AbdAYQMX (ORCPT ); Wed, 25 Jan 2017 11:12:23 -0500 Received: from Galois.linutronix.de ([146.0.238.70]:46246 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750729AbdAYQMW (ORCPT ); Wed, 25 Jan 2017 11:12:22 -0500 Date: Wed, 25 Jan 2017 17:12:17 +0100 From: Sebastian Andrzej Siewior To: Peter Zijlstra , x86@kernel.org Cc: John Ogness , linux-rt-users , linux-kernel@vger.kernel.org, Thomas Gleixner Subject: Re: [PATCH] x86/mm/cpa: avoid wbinvd() for PREEMPT_RT_FULL Message-ID: <20170125161217.k6h5weu34i2knl3f@linutronix.de> References: <87o9z1ic9a.fsf@linutronix.de> <20170121141915.GT6485@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170121141915.GT6485@twins.programming.kicks-ass.net> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017-01-21 15:19:15 [+0100], Peter Zijlstra wrote: > On Fri, Jan 20, 2017 at 11:42:57PM +0100, John Ogness wrote: > > Although wbinvd() is faster than flushing many individual pages, it > > blocks the memory bus for "long" periods of time (>100us), thus > > directly causing unusually large latencies for PREEMPT_RT_FULL. For > > 1024 pages, flushing those pages individually can take up to 2200us, > > but the task remains fully preemptible during that time. > > > > Cc: Peter Zijlstra > > Cc: Sebastian Andrzej Siewior > > Signed-off-by: John Ogness > > --- > > arch/x86/mm/pageattr.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/arch/x86/mm/pageattr.c b/arch/x86/mm/pageattr.c > > index e3353c9..a182477 100644 > > --- a/arch/x86/mm/pageattr.c > > +++ b/arch/x86/mm/pageattr.c > > @@ -214,7 +214,12 @@ static void cpa_flush_array(unsigned long *start, int numpages, int cache, > > int in_flags, struct page **pages) > > { > > unsigned int i, level; > > +#ifdef CONFIG_PREEMPT_RT_FULL > > + /* wbinvd() causes ugly latencies, avoid it */ > > + unsigned long do_wbinvd = 0; > > Arguably we should do the same for CONFIG_PREEMPT and possibly even > always, esp. when considering CAT. So you want to see this patch again with CONFIG_PREEMPT instead of CONFIG_PREEMPT_RT_FULL and also targeting lkml? I don't get quite the link between wbindv and CAT (assuming it stands for Intel's Cache Allocation support). But if you want unconditionally want to drop that wbinvd because it is bad for another !RT usecase, fine by me :) Any preferences from the x86 folks? Sebastian