From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751742AbdAYQ1L (ORCPT ); Wed, 25 Jan 2017 11:27:11 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33612 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751094AbdAYQ1K (ORCPT ); Wed, 25 Jan 2017 11:27:10 -0500 From: Vitaly Kuznetsov To: devel@linuxdriverproject.org Cc: linux-kernel@vger.kernel.org, "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger Subject: [PATCH] Drivers: hv: balloon: add a comment explaining fall through in hv_memory_notifier() Date: Wed, 25 Jan 2017 17:27:08 +0100 Message-Id: <20170125162708.6264-1-vkuznets@redhat.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Wed, 25 Jan 2017 16:27:11 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Coverity scan gives a warning when there is fall through in a switch without a comment. Reported-by: Stephen Hemminger Signed-off-by: Vitaly Kuznetsov --- drivers/hv/hv_balloon.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/hv/hv_balloon.c b/drivers/hv/hv_balloon.c index 14c3dc4..7e2479f 100644 --- a/drivers/hv/hv_balloon.c +++ b/drivers/hv/hv_balloon.c @@ -587,6 +587,12 @@ static int hv_memory_notifier(struct notifier_block *nb, unsigned long val, spin_lock_irqsave(&dm_device.ha_lock, flags); dm_device.num_pages_onlined += mem->nr_pages; spin_unlock_irqrestore(&dm_device.ha_lock, flags); + /* + * Fall through - ol_waitevent needs to be completed to unblock + * hv_mem_hot_add() allowing it to process next requests + * regardless of the result of if we were able to online this + * block. + */ case MEM_CANCEL_ONLINE: if (dm_device.ha_waiting) { dm_device.ha_waiting = false; -- 2.9.3