From: Arnd Bergmann <arnd@arndb.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Yisheng Xie <xieyisheng1@huawei.com>,
Michal Hocko <mhocko@kernel.org>,
Minchan Kim <minchan@kernel.org>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Arnd Bergmann <arnd@arndb.de>, Vlastimil Babka <vbabka@suse.cz>,
Gioh Kim <gi-oh.kim@profitbricks.com>,
Ganesh Mahendran <opensource.ganesh@gmail.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH] mm: migrate: add isolate_movable_page() stub implementation
Date: Wed, 25 Jan 2017 23:27:38 +0100 [thread overview]
Message-ID: <20170125222752.1314498-1-arnd@arndb.de> (raw)
Without CONFIG_MIGRATION, we get a build failure when trying to
call isolate_movable_page():
mm/memory-failure.c: In function '__soft_offline_page':
mm/memory-failure.c:1656:10: error: implicit declaration of function 'isolate_movable_page';did you mean 'isolate_huge_page'? [-Werror=implicit-function-declaration]
This adds one more static inline helper function in the header
declaring it. This returns false to indicate that the
page was not isolated.
Fixes: mmotm ("HWPOISON: soft offlining for non-lru movable pages")
Fixes: bda807d44454 ("mm: migrate: support non-lru movable page migration")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
include/linux/migrate.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/linux/migrate.h b/include/linux/migrate.h
index ae8d475a9385..09dd6e924106 100644
--- a/include/linux/migrate.h
+++ b/include/linux/migrate.h
@@ -57,6 +57,9 @@ static inline int migrate_pages(struct list_head *l, new_page_t new,
int reason)
{ return -ENOSYS; }
+static inline bool isolate_movable_page(struct page *page, isolate_mode_t mode)
+ { return false; }
+
static inline int migrate_prep(void) { return -ENOSYS; }
static inline int migrate_prep_local(void) { return -ENOSYS; }
--
2.9.0
next reply other threads:[~2017-01-25 22:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-25 22:27 Arnd Bergmann [this message]
2017-01-26 7:39 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170125222752.1314498-1-arnd@arndb.de \
--to=arnd@arndb.de \
--cc=akpm@linux-foundation.org \
--cc=gi-oh.kim@profitbricks.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@kernel.org \
--cc=minchan@kernel.org \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=opensource.ganesh@gmail.com \
--cc=vbabka@suse.cz \
--cc=xieyisheng1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®