From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752716AbdAYXG4 (ORCPT ); Wed, 25 Jan 2017 18:06:56 -0500 Received: from mga02.intel.com ([134.134.136.20]:11556 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752457AbdAYXGy (ORCPT ); Wed, 25 Jan 2017 18:06:54 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,286,1477983600"; d="scan'208";a="52444500" Date: Thu, 26 Jan 2017 01:06:51 +0200 From: Jarkko Sakkinen To: Ken Goldman Cc: linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, tpmdd-devel@lists.sourceforge.net Subject: Re: [tpmdd-devel] [PATCH v9 2/2] tpm: add securityfs support,for TPM 2.0 firmware event log Message-ID: <20170125230651.zwvcyxpcrssfhyfu@intel.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 25, 2017 at 04:22:45PM -0500, Ken Goldman wrote: > > You do not need to send a new patch set version as long as this > > one gets peer tested. And it needs to be tested without hacks > > like plumbing TCPA with TPM 2.0 in QEMU. OF code paths needs to > > be peer tested to be more specific. > > > > For me the code itself looks good but I simply cannot take it in > > in the current situation. > > > > /Jarkko > > Tested-by: Kenneth Goldman > > I validated a firmware event log taken from a Power 8 against PCR 0-7 values > for the SHA-1 and SHA-256 banks from a Nuvoton TPM 2.0 chip on that same > platform. Thank you! I'll add this to the commit. /Jarkko