From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751556AbdAYXdl (ORCPT ); Wed, 25 Jan 2017 18:33:41 -0500 Received: from mga06.intel.com ([134.134.136.31]:47765 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750711AbdAYXdj (ORCPT ); Wed, 25 Jan 2017 18:33:39 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,286,1477983600"; d="scan'208";a="57278380" Date: Thu, 26 Jan 2017 01:33:35 +0200 From: Jarkko Sakkinen To: Nayna Jain Cc: tpmdd-devel@lists.sourceforge.net, peterhuewe@gmx.de, tpmdd@selhorst.net, jgunthorpe@obsidianresearch.com, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 0/2] enhance TPM 2.0 extend function to support multiple PCR banks Message-ID: <20170125233335.g5dmj43bgrulwmva@intel.com> References: <1484931913-24909-1-git-send-email-nayna@linux.vnet.ibm.com> <20170125204535.bduqiywtlvgidoj6@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170125204535.bduqiywtlvgidoj6@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 25, 2017 at 10:45:35PM +0200, Jarkko Sakkinen wrote: > On Fri, Jan 20, 2017 at 12:05:11PM -0500, Nayna Jain wrote: > > IMA extends its hash measurements in the TPM PCRs, based on policy. > > The existing in-kernel TPM extend function extends only the SHA1 > > PCR bank. TPM 2.0 defines multiple PCR banks, to support different > > hash algorithms. The TCG TPM 2.0 Specification[1] recommends > > extending all active PCR banks to prevent malicious users from > > setting unused PCR banks with fake measurements and quoting them. > > This patch set adds support for extending all active PCR banks, > > as recommended. > > > > The first patch implements the TPM 2.0 capability to retrieve > > the list of active PCR banks. > > > > The second patch modifies the tpm_pcr_extend() and tpm2_pcr_extend() > > interface to support extending multiple PCR banks. The existing > > tpm_pcr_extend() interface expects only a SHA1 digest. Hence, to > > extend all active PCR banks with differing digest sizes for TPM 2.0, > > the SHA1 digest is padded with 0's as needed. > > > > [1] TPM 2.0 Specification referred here is "TCG PC Client Specific > > Platform Firmware Profile for TPM 2.0" > > I pushed these patches. I had to resolve merge conflicts caused > by the min_rsp_body_length parameter in tpm_transmit_cmd. Can you > verify that I didn't break anything? You have a bug in tpm2_get_pcr_allocation: rc = tpm_transmit_cmd(chip, buf.data, PAGE_SIZE, 9, 0, "get tpm pcr allocation"); if (rc < 0) goto out; You do not handle TPM error. Can you send a fix for this ASAP? /Jarkko