From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753468AbdAZTzy (ORCPT ); Thu, 26 Jan 2017 14:55:54 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:41620 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753060AbdAZTzv (ORCPT ); Thu, 26 Jan 2017 14:55:51 -0500 Date: Thu, 26 Jan 2017 14:00:33 -0500 (EST) Message-Id: <20170126.140033.1039326394984007010.davem@davemloft.net> To: arnd@arndb.de Cc: mac@melware.de, isdn@linux-pingi.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [net-next] ISDN: eicon: reduce stack size of sig_ind function From: David Miller In-Reply-To: <20170125221607.1102271-1-arnd@arndb.de> References: <20170125221607.1102271-1-arnd@arndb.de> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 26 Jan 2017 10:01:31 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann Date: Wed, 25 Jan 2017 23:15:53 +0100 > I noticed that this function uses a lot of kernel stack when the > "latent entropy" plugin is enabled: > > drivers/isdn/hardware/eicon/message.c: In function 'sig_ind': > drivers/isdn/hardware/eicon/message.c:6113:1: error: the frame size of 1168 bytes is larger than 1152 bytes [-Werror=frame-larger-than=] > > We currently don't warn about this, as we raise the warning limit > to 2048 bytes in mainline, but I'd like to lower that limit again > in the future, and this function can easily be changed to be more > efficient and avoid that warning, by making some of its local > variables 'const'. > > Signed-off-by: Arnd Bergmann Applied, thanks Arnd.