From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752854AbdAZHje (ORCPT <rfc822;w@1wt.eu>);
        Thu, 26 Jan 2017 02:39:34 -0500
Received: from mx2.suse.de ([195.135.220.15]:59290 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752536AbdAZHjd (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 26 Jan 2017 02:39:33 -0500
Date: Thu, 26 Jan 2017 08:39:30 +0100
From: Michal Hocko <mhocko@kernel.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
        Yisheng Xie <xieyisheng1@huawei.com>, Minchan Kim <minchan@kernel.org>,
        Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
        Vlastimil Babka <vbabka@suse.cz>,
        Gioh Kim <gi-oh.kim@profitbricks.com>,
        Ganesh Mahendran <opensource.ganesh@gmail.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: migrate: add isolate_movable_page() stub
 implementation
Message-ID: <20170126073930.GA8456@dhcp22.suse.cz>
References: <20170125222752.1314498-1-arnd@arndb.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170125222752.1314498-1-arnd@arndb.de>
User-Agent: Mutt/1.6.0 (2016-04-01)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

JFYI, Yisheng Xie has already posted a new version of the patchset [1]
and I assume Andrew will drop the current one.

[1] http://lkml.kernel.org/r/1485356738-4831-1-git-send-email-ysxie@foxmail.com

On Wed 25-01-17 23:27:38, Arnd Bergmann wrote:
> Without CONFIG_MIGRATION, we get a build failure when trying to
> call isolate_movable_page():
> 
> mm/memory-failure.c: In function '__soft_offline_page':
> mm/memory-failure.c:1656:10: error: implicit declaration of function 'isolate_movable_page';did you mean 'isolate_huge_page'? [-Werror=implicit-function-declaration]
> 
> This adds one more static inline helper function in the header
> declaring it. This returns false to indicate that the
> page was not isolated.
> 
> Fixes: mmotm ("HWPOISON: soft offlining for non-lru movable pages")
> Fixes: bda807d44454 ("mm: migrate: support non-lru movable page migration")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  include/linux/migrate.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/include/linux/migrate.h b/include/linux/migrate.h
> index ae8d475a9385..09dd6e924106 100644
> --- a/include/linux/migrate.h
> +++ b/include/linux/migrate.h
> @@ -57,6 +57,9 @@ static inline int migrate_pages(struct list_head *l, new_page_t new,
>  		int reason)
>  	{ return -ENOSYS; }
>  
> +static inline bool isolate_movable_page(struct page *page, isolate_mode_t mode)
> +	{ return false; }
> +
>  static inline int migrate_prep(void) { return -ENOSYS; }
>  static inline int migrate_prep_local(void) { return -ENOSYS; }
>  
> -- 
> 2.9.0

-- 
Michal Hocko
SUSE Labs