From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753469AbdAZJxs (ORCPT ); Thu, 26 Jan 2017 04:53:48 -0500 Received: from mx2.suse.de ([195.135.220.15]:43221 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753306AbdAZJxq (ORCPT ); Thu, 26 Jan 2017 04:53:46 -0500 Date: Thu, 26 Jan 2017 09:52:25 +0000 From: Mel Gorman To: Johannes Weiner Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH 1/5] mm: vmscan: scan dirty pages even in laptop mode Message-ID: <20170126095225.kvv546uvofie25ym@suse.de> References: <20170123181641.23938-1-hannes@cmpxchg.org> <20170123181641.23938-2-hannes@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20170123181641.23938-2-hannes@cmpxchg.org> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 23, 2017 at 01:16:37PM -0500, Johannes Weiner wrote: > We have an elaborate dirty/writeback throttling mechanism inside the > reclaim scanner, but for that to work the pages have to go through > shrink_page_list() and get counted for what they are. Otherwise, we > mess up the LRU order and don't match reclaim speed to writeback. > > Especially during deactivation, there is never a reason to skip dirty > pages; nothing is even trying to write them out from there. Don't mess > up the LRU order for nothing, shuffle these pages along. > > Signed-off-by: Johannes Weiner Acked-by: Mel Gorman -- Mel Gorman SUSE Labs