From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752660AbdAZCh4 (ORCPT ); Wed, 25 Jan 2017 21:37:56 -0500 Received: from mail.kernel.org ([198.145.29.136]:60668 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752453AbdAZChy (ORCPT ); Wed, 25 Jan 2017 21:37:54 -0500 Date: Thu, 26 Jan 2017 11:37:43 +0900 From: Masami Hiramatsu To: Josh Hunt Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Alexander Shishkin , linux-kernel@vger.kernel.org, mhiramat@kernel.org, bgregg@netflix.com Subject: Re: [PATCH] perf probe: Ignore vmlinux build-id when offline vmlinux and dry-run used Message-Id: <20170126113743.2abec2b978377e31a450334b@kernel.org> In-Reply-To: <1485294088-17361-1-git-send-email-johunt@akamai.com> References: <1485294088-17361-1-git-send-email-johunt@akamai.com> X-Mailer: Sylpheed 3.5.0 (GTK+ 2.24.30; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 24 Jan 2017 16:41:28 -0500 Josh Hunt wrote: > Commit e50243bb ("perf probe: Ignore vmlinux Build-id when offline vmlinux given") > added the ability to ignore vmlinux when an offline vmlinux is passed and no > l, d, or a flag is also passed. This extends that to ignore build-id when > -n/--dry-run is used. This way we can gather probe information for offline kernels > using the method Brendan Gregg mentions in this post: > http://www.brendangregg.com/blog/2014-09-11/perf-kernel-line-tracing.html . Sorry, NAK. Could you use -D (--definition) for that usage? It directly gives you the definition on stdout, and also ignore the buildid. Thank you, > > Ex: > $ ./perf probe -k ./vmlinux-3.14.59 -nv 'do_sys_open=do_sys_open:7 filename:string dfd flags op' > > will generate: > do_sys_open+91 filename_string=+0(%si):string dfd=%di:s32 flags=%bx:s32 op=-60(%bp):u64 > > and then copy/paste this to the machine running the 3.14.59 kernel. > > Signed-off-by: Josh Hunt > --- > tools/perf/builtin-probe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/builtin-probe.c b/tools/perf/builtin-probe.c > index f87996b..e0eea723 100644 > --- a/tools/perf/builtin-probe.c > +++ b/tools/perf/builtin-probe.c > @@ -616,7 +616,7 @@ static int perf_del_probe_events(struct strfilter *filter) > * nor change running kernel. So if user gives offline vmlinux, > * ignore its buildid. > */ > - if (!strchr("lda", params.command) && symbol_conf.vmlinux_name) > + if ((!strchr("lda", params.command) || probe_event_dry_run) && symbol_conf.vmlinux_name) > symbol_conf.ignore_vmlinux_buildid = true; > > switch (params.command) { > -- > 1.9.1 > -- Masami Hiramatsu