From: Michal Hocko <mhocko@kernel.org>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mgorman@suse.de>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
kernel-team@fb.com
Subject: Re: [PATCH 2/5] mm: vmscan: kick flushers when we encounter dirty pages on the LRU
Date: Thu, 26 Jan 2017 14:16:34 +0100 [thread overview]
Message-ID: <20170126131634.GB7827@dhcp22.suse.cz> (raw)
In-Reply-To: <20170123181641.23938-3-hannes@cmpxchg.org>
On Mon 23-01-17 13:16:38, Johannes Weiner wrote:
> Memory pressure can put dirty pages at the end of the LRU without
> anybody running into dirty limits. Don't start writing individual
> pages from kswapd while the flushers might be asleep.
>
> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
Acked-by: Michal Hocko <mhocko@suse.com>
> ---
> include/linux/writeback.h | 2 +-
> include/trace/events/writeback.h | 2 +-
> mm/vmscan.c | 18 +++++++++++++-----
> 3 files changed, 15 insertions(+), 7 deletions(-)
>
> diff --git a/include/linux/writeback.h b/include/linux/writeback.h
> index 5527d910ba3d..a3c0cbd7c888 100644
> --- a/include/linux/writeback.h
> +++ b/include/linux/writeback.h
> @@ -46,7 +46,7 @@ enum writeback_sync_modes {
> */
> enum wb_reason {
> WB_REASON_BACKGROUND,
> - WB_REASON_TRY_TO_FREE_PAGES,
> + WB_REASON_VMSCAN,
> WB_REASON_SYNC,
> WB_REASON_PERIODIC,
> WB_REASON_LAPTOP_TIMER,
> diff --git a/include/trace/events/writeback.h b/include/trace/events/writeback.h
> index 2ccd9ccbf9ef..7bd8783a590f 100644
> --- a/include/trace/events/writeback.h
> +++ b/include/trace/events/writeback.h
> @@ -31,7 +31,7 @@
>
> #define WB_WORK_REASON \
> EM( WB_REASON_BACKGROUND, "background") \
> - EM( WB_REASON_TRY_TO_FREE_PAGES, "try_to_free_pages") \
> + EM( WB_REASON_VMSCAN, "vmscan") \
> EM( WB_REASON_SYNC, "sync") \
> EM( WB_REASON_PERIODIC, "periodic") \
> EM( WB_REASON_LAPTOP_TIMER, "laptop_timer") \
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index 0d05f7f3b532..56ea8d24041f 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -1798,12 +1798,20 @@ shrink_inactive_list(unsigned long nr_to_scan, struct lruvec *lruvec,
>
> /*
> * If dirty pages are scanned that are not queued for IO, it
> - * implies that flushers are not keeping up. In this case, flag
> - * the pgdat PGDAT_DIRTY and kswapd will start writing pages from
> - * reclaim context.
> + * implies that flushers are not doing their job. This can
> + * happen when memory pressure pushes dirty pages to the end
> + * of the LRU without the dirty limits being breached. It can
> + * also happen when the proportion of dirty pages grows not
> + * through writes but through memory pressure reclaiming all
> + * the clean cache. And in some cases, the flushers simply
> + * cannot keep up with the allocation rate. Nudge the flusher
> + * threads in case they are asleep, but also allow kswapd to
> + * start writing pages during reclaim.
> */
> - if (stat.nr_unqueued_dirty == nr_taken)
> + if (stat.nr_unqueued_dirty == nr_taken) {
> + wakeup_flusher_threads(0, WB_REASON_VMSCAN);
> set_bit(PGDAT_DIRTY, &pgdat->flags);
> + }
>
> /*
> * If kswapd scans pages marked marked for immediate
> @@ -2787,7 +2795,7 @@ static unsigned long do_try_to_free_pages(struct zonelist *zonelist,
> writeback_threshold = sc->nr_to_reclaim + sc->nr_to_reclaim / 2;
> if (total_scanned > writeback_threshold) {
> wakeup_flusher_threads(laptop_mode ? 0 : total_scanned,
> - WB_REASON_TRY_TO_FREE_PAGES);
> + WB_REASON_VMSCAN);
> sc->may_writepage = 1;
> }
> } while (--sc->priority >= 0);
> --
> 2.11.0
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2017-01-26 13:16 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-23 18:16 [PATCH 0/5] mm: vmscan: fix kswapd writeback regression Johannes Weiner
2017-01-23 18:16 ` [PATCH 1/5] mm: vmscan: scan dirty pages even in laptop mode Johannes Weiner
2017-01-26 1:27 ` Minchan Kim
2017-01-26 9:52 ` Mel Gorman
2017-01-26 13:13 ` Michal Hocko
2017-01-23 18:16 ` [PATCH 2/5] mm: vmscan: kick flushers when we encounter dirty pages on the LRU Johannes Weiner
2017-01-26 1:35 ` Minchan Kim
2017-01-26 9:57 ` Mel Gorman
2017-01-26 17:47 ` Johannes Weiner
2017-01-26 18:47 ` Mel Gorman
2017-01-26 13:16 ` Michal Hocko [this message]
2017-01-23 18:16 ` [PATCH 3/5] mm: vmscan: remove old flusher wakeup from direct reclaim path Johannes Weiner
2017-01-26 1:38 ` Minchan Kim
2017-01-26 10:05 ` Mel Gorman
2017-01-26 18:50 ` Johannes Weiner
2017-01-26 20:45 ` Mel Gorman
2017-01-27 12:01 ` Michal Hocko
2017-01-27 14:27 ` Mel Gorman
2017-01-26 13:21 ` Michal Hocko
2017-01-23 18:16 ` [PATCH 4/5] mm: vmscan: only write dirty pages that the scanner has seen twice Johannes Weiner
2017-01-26 1:42 ` Minchan Kim
2017-01-26 10:08 ` Mel Gorman
2017-01-26 13:29 ` Michal Hocko
2017-01-23 18:16 ` [PATCH 5/5] mm: vmscan: move dirty pages out of the way until they're flushed Johannes Weiner
2017-01-26 1:47 ` Minchan Kim
2017-01-26 10:19 ` Mel Gorman
2017-01-26 20:07 ` Johannes Weiner
2017-01-26 20:58 ` Mel Gorman
2017-01-26 13:52 ` Michal Hocko
2017-01-26 5:44 ` [PATCH 0/5] mm: vmscan: fix kswapd writeback regression Hillf Danton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170126131634.GB7827@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®