From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753371AbdAZTjP (ORCPT ); Thu, 26 Jan 2017 14:39:15 -0500 Received: from mail-wm0-f65.google.com ([74.125.82.65]:33618 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753324AbdAZTjM (ORCPT ); Thu, 26 Jan 2017 14:39:12 -0500 Date: Thu, 26 Jan 2017 21:38:46 +0200 From: Krzysztof Kozlowski To: Marek Szyprowski Cc: Kukjin Kim , Javier Martinez Canillas , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Sylwester Nawrocki Subject: Re: [PATCH 1/2] soc: samsung: pmu: Remove unused and duplicated defines Message-ID: <20170126193846.hbo6a5yvbp3opfs4@kozik-lap> References: <20170125193452.31768-1-krzk@kernel.org> <20251f7e-310a-223e-3a35-7df5bc30352a@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20251f7e-310a-223e-3a35-7df5bc30352a@samsung.com> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 26, 2017 at 08:15:42AM +0100, Marek Szyprowski wrote: > Hi Krzysztof, > > > On 2017-01-25 20:34, Krzysztof Kozlowski wrote: > > The exynos-regs-pmu.h was never a complete list of PMU registers. It > > contained a lot of holes for registers which are not used. However, a > > lot of unused defines came with porting the code from vendor kernel. > > > > Few of defines were also duplicated. > > > > Remove them so the file will be slightly smaller. > > > > Signed-off-by: Krzysztof Kozlowski > > Thanks for the cleanup! > > If you are touching this, you may also want to unify multiple headers for > the Exynos PMU regs: > include/linux/soc/samsung/exynos-regs-pmu.h > linux/mfd/syscon/exynos4-pmu.h > linux/mfd/syscon/exynos5-pmu.h > Sure, I'll take a look at these as well. Thanks for a hint. Best regards, Krzysztof