From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753463AbdA0ASu (ORCPT ); Thu, 26 Jan 2017 19:18:50 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:36678 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752538AbdA0ASs (ORCPT ); Thu, 26 Jan 2017 19:18:48 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 5B43860859 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sboyd@codeaurora.org Date: Thu, 26 Jan 2017 16:18:46 -0800 From: Stephen Boyd To: Leo Yan Cc: Michael Turquette , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Guodong Xu , Haojian Zhuang , John Stultz Subject: Re: [PATCH v2] clk: hisilicon: fix lock assignment Message-ID: <20170127001846.GV8801@codeaurora.org> References: <1484965591-743-1-git-send-email-leo.yan@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1484965591-743-1-git-send-email-leo.yan@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/21, Leo Yan wrote: > In clock driver initialize phase the spinlock is missed to assignment > to struct clkgate_separated, finally there have no locking to protect > exclusive accessing for clock registers. > > This bug introduces the console has no output after enable coresight > driver on 96boards Hikey; this is because console using UART3, which > has shared the same register with coresight clock enabling bit. After > applied this patch it can assign lock properly to protect exclusive > accessing, and console can work well after enabled coresight modules. > > Fixes: 0aa0c95f743a ("clk: hisilicon: add common clock support") > Signed-off-by: Leo Yan > --- Applied to clk-next -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project