From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754226AbdA0HhO (ORCPT ); Fri, 27 Jan 2017 02:37:14 -0500 Received: from mail-wm0-f68.google.com ([74.125.82.68]:32857 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754018AbdA0HhN (ORCPT ); Fri, 27 Jan 2017 02:37:13 -0500 Date: Fri, 27 Jan 2017 08:30:40 +0100 From: Daniel Vetter To: Thomas Hellstrom Cc: Michel =?iso-8859-1?Q?D=E4nzer?= , Sinclair Yeh , Christian =?iso-8859-1?Q?K=F6nig?= , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Daniel Vetter Subject: Re: [PATCH] drm/ttm: Make sure BOs being swapped out are cacheable Message-ID: <20170127073040.l2ofthrhsbteahpx@phenom.ffwll.local> Mail-Followup-To: Thomas Hellstrom , Michel =?iso-8859-1?Q?D=E4nzer?= , Sinclair Yeh , Christian =?iso-8859-1?Q?K=F6nig?= , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20170125082131.25544-1-michel@daenzer.net> <56e0a49e-89b6-4542-e905-57f0dc2ae79c@amd.com> <20170126004632.GA3457@vmware.com> <9af4b5b5-a8a5-8908-f59f-6cdc8efe0570@daenzer.net> <5778f881-ce81-1c58-f2d4-02175c3d2615@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5778f881-ce81-1c58-f2d4-02175c3d2615@vmware.com> X-Operating-System: Linux phenom 4.8.0-1-amd64 User-Agent: NeoMutt/20161126 (1.7.1) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 27, 2017 at 07:23:58AM +0100, Thomas Hellstrom wrote: > On 01/27/2017 03:29 AM, Michel Dänzer wrote: > > On 26/01/17 09:46 AM, Sinclair Yeh wrote: > >> On Wed, Jan 25, 2017 at 10:49:33AM +0100, Christian König wrote: > >>> Am 25.01.2017 um 10:25 schrieb Thomas Hellstrom: > >>>> On 01/25/2017 09:21 AM, Michel Dänzer wrote: > >>>>> From: Michel Dänzer > >>>>> > >>>>> The current caching state may not be tt_cached, even though the > >>>>> placement contains TTM_PL_FLAG_CACHED, because placement can contain > >>>>> multiple caching flags. Trying to swap out such a BO would trip up the > >>>>> > >>>>> BUG_ON(ttm->caching_state != tt_cached); > >>>>> > >>>>> in ttm_tt_swapout. > >>>>> > >>>>> Cc: stable@vger.kernel.org > >>>>> Signed-off-by: Michel Dänzer > >>>> Reviewed-by: Thomas Hellstrom > >>> Reviewed-by: Christian König . > >> Reviewed-by: Sinclair Yeh > > Thanks for the reviews! Via which tree should we merge this? > > > > > I don't maintain a TTM tree any longer. Let's check with Daniel if he > can merge it through drm-misc. I'm trying very hard not to get volunteered for ttm maintainer :-) Nominally Alex&Christian have drm-misc commit rights, but they haven't used them yet. But I think merging through drm-misc would make sense, there's regular pull request trains for both -next and -fixes. Or merge through the amd tree with Dave's ack, but I'd really like to get amd folks into the drm-misc group ... -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch