mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Tomas Winkler <tomas.winkler@intel.com>
Cc: Alexander Usyskin <alexander.usyskin@intel.com>,
	linux-kernel@vger.kernel.org,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [char-misc-next V3] mei: simplify error handling via devres function.
Date: Fri, 27 Jan 2017 09:15:15 +0100	[thread overview]
Message-ID: <20170127081515.GA29246@kroah.com> (raw)
In-Reply-To: <1485443786-27337-1-git-send-email-tomas.winkler@intel.com>

On Thu, Jan 26, 2017 at 05:16:26PM +0200, Tomas Winkler wrote:
> Use devm_ and pcim_ functions to make error handling
> simpler and code smaller and tidier.
> 
> Based on original patch by
> mei: me: use managed functions pcim_* and devm_*
> https://lkml.org/lkml/2016/2/1/339
> 
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> V2: Thanks Andy for review, integratd changes:
>     1. Rename devm_mei_me_init back to mei_me_dev_init
>        they don't really belong to devm_ namespace.
>     2. Revert pcim irq reservation change.
>     3. Drop setting driver data to NULL on exit.
>     4. Use directly mmio pointer received from pcim_iomap_table
> V3: Remove pci_disable_msi, it is also handled by the system.

Andy, any objection to this version?

thanks,

greg k-h

  reply	other threads:[~2017-01-27  8:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-26 15:16 Tomas Winkler
2017-01-27  8:15 ` Greg Kroah-Hartman [this message]
2017-01-27 13:19   ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170127081515.GA29246@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=alexander.usyskin@intel.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tomas.winkler@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome