From: Mark Brown <broonie@kernel.org>
To: Dmitry Torokhov <dtor@chromium.org>
Cc: Daniel Kurtz <djkurtz@chromium.org>,
Robin Murphy <robin.murphy@arm.com>,
Leilk Liu <leilk.liu@mediatek.com>,
open list <linux-kernel@vger.kernel.org>,
"open list:SPI SUBSYSTEM" <linux-spi@vger.kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
Guenter Roeck <groeck@chromium.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] spi: mediatek: Manually set dma_ops for spi_master device
Date: Fri, 27 Jan 2017 13:36:21 +0000 [thread overview]
Message-ID: <20170127133621.bifp64y2cdljld65@sirena.org.uk> (raw)
In-Reply-To: <CAE_wzQ-an3v_32E+JFzTQMKXf=J6BVGf56QZKL+YCV=mZk6-LA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 590 bytes --]
On Thu, Jan 26, 2017 at 09:26:13AM -0800, Dmitry Torokhov wrote:
> OTOH the full buffer used by cros ec *is* DMA-safe (allocated with
> kmalloc), it is that cors ec uses it at offset while transferring data
> piece by piece. Do we want to support this?
I'm not sure the complexity is worth it as a general feature, I worry
about the cost of worrying about cutting the transaction up to include a
PIO portion. That said that's just a gut feeling, if there were a
sufficiently simple/nice implementation it'd definitely avoid bugs.
To me part of DMA safety is the alignment restrictions.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2017-01-27 13:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-24 13:25 Daniel Kurtz
2017-01-24 15:14 ` Robin Murphy
2017-01-25 10:24 ` Daniel Kurtz
2017-01-25 12:34 ` Mark Brown
2017-01-25 17:59 ` Robin Murphy
2017-01-26 16:29 ` Daniel Kurtz
2017-01-26 16:35 ` Dmitry Torokhov
2017-01-26 16:52 ` Daniel Kurtz
2017-01-26 17:07 ` Mark Brown
2017-01-26 17:26 ` Dmitry Torokhov
2017-01-27 13:36 ` Mark Brown [this message]
2017-01-24 15:48 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170127133621.bifp64y2cdljld65@sirena.org.uk \
--to=broonie@kernel.org \
--cc=djkurtz@chromium.org \
--cc=dtor@chromium.org \
--cc=groeck@chromium.org \
--cc=leilk.liu@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®