From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755076AbdA0Owf (ORCPT ); Fri, 27 Jan 2017 09:52:35 -0500 Received: from mail-wm0-f66.google.com ([74.125.82.66]:34306 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754795AbdA0Ow0 (ORCPT ); Fri, 27 Jan 2017 09:52:26 -0500 Date: Fri, 27 Jan 2017 15:52:15 +0100 From: Daniel Vetter To: Christian =?iso-8859-1?Q?K=F6nig?= Cc: Thomas Hellstrom , Michel =?iso-8859-1?Q?D=E4nzer?= , Sinclair Yeh , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/ttm: Make sure BOs being swapped out are cacheable Message-ID: <20170127145215.uto6flnudabrpnmz@phenom.ffwll.local> Mail-Followup-To: Christian =?iso-8859-1?Q?K=F6nig?= , Thomas Hellstrom , Michel =?iso-8859-1?Q?D=E4nzer?= , Sinclair Yeh , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20170125082131.25544-1-michel@daenzer.net> <56e0a49e-89b6-4542-e905-57f0dc2ae79c@amd.com> <20170126004632.GA3457@vmware.com> <9af4b5b5-a8a5-8908-f59f-6cdc8efe0570@daenzer.net> <5778f881-ce81-1c58-f2d4-02175c3d2615@vmware.com> <20170127073040.l2ofthrhsbteahpx@phenom.ffwll.local> <5e8d77b2-8b71-6542-4ef5-c7a5d16f2455@amd.com> <20170127141249.4tft6eajtw35pcho@phenom.ffwll.local> <2b8ceab6-f419-0670-0df9-77e726177742@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2b8ceab6-f419-0670-0df9-77e726177742@amd.com> X-Operating-System: Linux phenom 4.8.0-1-amd64 User-Agent: NeoMutt/20161126 (1.7.1) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 27, 2017 at 03:43:18PM +0100, Christian König wrote: > Am 27.01.2017 um 15:12 schrieb Daniel Vetter: > > On Fri, Jan 27, 2017 at 09:22:47AM +0100, Christian König wrote: > > > Am 27.01.2017 um 08:30 schrieb Daniel Vetter: > > > > On Fri, Jan 27, 2017 at 07:23:58AM +0100, Thomas Hellstrom wrote: > > > > > On 01/27/2017 03:29 AM, Michel Dänzer wrote: > > > > > > On 26/01/17 09:46 AM, Sinclair Yeh wrote: > > > > > > > On Wed, Jan 25, 2017 at 10:49:33AM +0100, Christian König wrote: > > > > > > > > Am 25.01.2017 um 10:25 schrieb Thomas Hellstrom: > > > > > > > > > On 01/25/2017 09:21 AM, Michel Dänzer wrote: > > > > > > > > > > From: Michel Dänzer > > > > > > > > > > > > > > > > > > > > The current caching state may not be tt_cached, even though the > > > > > > > > > > placement contains TTM_PL_FLAG_CACHED, because placement can contain > > > > > > > > > > multiple caching flags. Trying to swap out such a BO would trip up the > > > > > > > > > > > > > > > > > > > > BUG_ON(ttm->caching_state != tt_cached); > > > > > > > > > > > > > > > > > > > > in ttm_tt_swapout. > > > > > > > > > > > > > > > > > > > > Cc: stable@vger.kernel.org > > > > > > > > > > Signed-off-by: Michel Dänzer > > > > > > > > > Reviewed-by: Thomas Hellstrom > > > > > > > > Reviewed-by: Christian König . > > > > > > > Reviewed-by: Sinclair Yeh > > > > > > Thanks for the reviews! Via which tree should we merge this? > > > > > > > > > > > > > > > > > I don't maintain a TTM tree any longer. Let's check with Daniel if he > > > > > can merge it through drm-misc. > > > > I'm trying very hard not to get volunteered for ttm maintainer :-) > > > Yeah, ok I volunteer. Wanted to take that over for a while anyway. > > I guess you didn't use the dim magic to push it? The test integration tree > > isn't rebuild ... Quickstart for the tooling: > > Autsch! Do I have to use that or can I just go with my usual tool set? > > Would probably be a pain to set this up everywhere here. We use it both for convience (e.g. it auto-adds the sob if need, and the patchwork link by default), and to catch mistakes (e.g. it checks that you're not pushing patches outside of the scope of drm-misc or i915 to the wrong tree). For drm-misc specifically there's also the 3 defconfigs you're supposed to build test before pushing (unfornately not scripted since distros can't even agree on what cross-compiler prefixes work for a given platform). And since 1 month ago we have an arm-soc ttm-based driver, so doing that for ttm patches is kinda a good idea too :-) But right now the main thing is this integration tree magic to regenerate drm-tip, and that's also what intel CI and kernelci from collabora beat on. Long term I'd love to push all this onto the server-side (github makes scipting a lot of this dead easy). But we're still stuck with patches scribbled on stones with emailed patches and all that, so client-side scripts are kinda needed. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch