From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933508AbdA0RQ6 (ORCPT ); Fri, 27 Jan 2017 12:16:58 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36120 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932902AbdA0RPl (ORCPT ); Fri, 27 Jan 2017 12:15:41 -0500 From: Benjamin Tissoires To: Dmitry Torokhov , Greg Kroah-Hartman , Jiri Slaby , Samuel Thibault Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/4] tty/vt/keyboard: use defined macros for masks Date: Fri, 27 Jan 2017 18:13:15 +0100 Message-Id: <20170127171318.2596-2-benjamin.tissoires@redhat.com> In-Reply-To: <20170127171318.2596-1-benjamin.tissoires@redhat.com> References: <20170127171318.2596-1-benjamin.tissoires@redhat.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Fri, 27 Jan 2017 17:13:26 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Better using the defined macros to express the bit masks. Signed-off-by: Benjamin Tissoires --- drivers/tty/vt/keyboard.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/tty/vt/keyboard.c b/drivers/tty/vt/keyboard.c index 3dd6a49..4a3907e 100644 --- a/drivers/tty/vt/keyboard.c +++ b/drivers/tty/vt/keyboard.c @@ -1044,9 +1044,9 @@ static int kbd_update_leds_helper(struct input_handle *handle, void *data) unsigned int leds = *(unsigned int *)data; if (test_bit(EV_LED, handle->dev->evbit)) { - input_inject_event(handle, EV_LED, LED_SCROLLL, !!(leds & 0x01)); - input_inject_event(handle, EV_LED, LED_NUML, !!(leds & 0x02)); - input_inject_event(handle, EV_LED, LED_CAPSL, !!(leds & 0x04)); + input_inject_event(handle, EV_LED, LED_SCROLLL, !!(leds & BIT(VC_SCROLLOCK))); + input_inject_event(handle, EV_LED, LED_NUML, !!(leds & BIT(VC_NUMLOCK))); + input_inject_event(handle, EV_LED, LED_CAPSL, !!(leds & BIT(VC_CAPSLOCK))); input_inject_event(handle, EV_SYN, SYN_REPORT, 0); } -- 2.9.3