From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933612AbdA0RS3 (ORCPT ); Fri, 27 Jan 2017 12:18:29 -0500 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:7578 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933541AbdA0RSN (ORCPT ); Fri, 27 Jan 2017 12:18:13 -0500 X-IronPort-AV: E=Sophos;i="5.33,296,1477954800"; d="scan'208";a="211184469" Date: Fri, 27 Jan 2017 18:18:10 +0100 From: Samuel Thibault To: Benjamin Tissoires Cc: Dmitry Torokhov , Greg Kroah-Hartman , Jiri Slaby , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] tty/vt/keyboard: use defined macros for masks Message-ID: <20170127171810.GV9511@var.bordeaux.inria.fr> Mail-Followup-To: Samuel Thibault , Benjamin Tissoires , Dmitry Torokhov , Greg Kroah-Hartman , Jiri Slaby , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org References: <20170127171318.2596-1-benjamin.tissoires@redhat.com> <20170127171318.2596-2-benjamin.tissoires@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170127171318.2596-2-benjamin.tissoires@redhat.com> User-Agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Benjamin Tissoires, on Fri 27 Jan 2017 18:13:15 +0100, wrote: > Better using the defined macros to express the bit masks. > > Signed-off-by: Benjamin Tissoires Reviewed-by: Samuel Thibault > --- > drivers/tty/vt/keyboard.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/tty/vt/keyboard.c b/drivers/tty/vt/keyboard.c > index 3dd6a49..4a3907e 100644 > --- a/drivers/tty/vt/keyboard.c > +++ b/drivers/tty/vt/keyboard.c > @@ -1044,9 +1044,9 @@ static int kbd_update_leds_helper(struct input_handle *handle, void *data) > unsigned int leds = *(unsigned int *)data; > > if (test_bit(EV_LED, handle->dev->evbit)) { > - input_inject_event(handle, EV_LED, LED_SCROLLL, !!(leds & 0x01)); > - input_inject_event(handle, EV_LED, LED_NUML, !!(leds & 0x02)); > - input_inject_event(handle, EV_LED, LED_CAPSL, !!(leds & 0x04)); > + input_inject_event(handle, EV_LED, LED_SCROLLL, !!(leds & BIT(VC_SCROLLOCK))); > + input_inject_event(handle, EV_LED, LED_NUML, !!(leds & BIT(VC_NUMLOCK))); > + input_inject_event(handle, EV_LED, LED_CAPSL, !!(leds & BIT(VC_CAPSLOCK))); > input_inject_event(handle, EV_SYN, SYN_REPORT, 0); > } > > -- > 2.9.3 > -- Samuel update-menus: relocation error: update-menus: symbol _ZNSt9basic_iosIcSt11char_traitsIcEE4initEPSt15basic_streambufIcS1_E, version GLIBCPP_3.2 not defined in file libstdc++.so.5 with link time reference quoi que ça peut bien vouloir dire ? N a eu la meme merde c ça que ça veut dire ? wow, c'est bien crypté :) -+- #ens-mim s'entraide -+-