From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752293AbdA1V33 (ORCPT ); Sat, 28 Jan 2017 16:29:29 -0500 Received: from mail.kernel.org ([198.145.29.136]:39966 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752272AbdA1V3W (ORCPT ); Sat, 28 Jan 2017 16:29:22 -0500 Date: Sat, 28 Jan 2017 15:29:12 -0600 From: Bjorn Helgaas To: Pankaj Dubey Cc: linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, jingoohan1@gmail.com, Niyas Ahmed S T , krzk@kernel.org, jh80.chung@samsung.com, kgene@kernel.org, alim.akhtar@samsung.com, bhelgaas@google.com, sanath@samsung.com Subject: Re: [PATCH v2] PCI: exynos: refactor exynos pcie driver Message-ID: <20170128212912.GK20550@bhelgaas-glaptop.roam.corp.google.com> References: <1483588418-2551-1-git-send-email-pankaj.dubey@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1483588418-2551-1-git-send-email-pankaj.dubey@samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 05, 2017 at 09:23:38AM +0530, Pankaj Dubey wrote: > From: Niyas Ahmed S T > > Currently Exynos PCIe driver is only supported for Exynos5440 SoC. > This patch does refactoring of Exynos PCIe driver to extend support > for other Exynos SoC. > > Following are the main changes done via this patch: > > 1) It adds separate structs for memory, clock resources. > > Reason behind this change is, moving ahead various Exynos SoC will > have different hardware resources such as iomem, clocks, regmap handles > etc. for PCIe controller, so keeping these resources in separate struct > will help us in intiailizing them via per SoC ops, and will avoid too > many of_machine_is_compatible in code, and help us simplifying > exynos_pcie struct. > > 2) It add exynos_pcie_ops struct which will allow us to support the > differences in resources in different Exynos SoC. > > No functional change intended. > > Signed-off-by: Niyas Ahmed S T > Signed-off-by: Pankaj Dubey > Acked-by: Krzysztof Kozlowski > Reviewed-by: Bartlomiej Zolnierkiewicz > --- > This patch set is prepared on top of Krzysztof's for-next and > PCIe driver cleanup patch [1] by Jaehoon Chung. > > [1]: https://lkml.org/lkml/2016/12/19/44 Jaehoon has posted an updated version since you posted this patch, so I assume this will need to be rebased on that. I'll drop this version and wait for your rebased version.