From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751670AbdA2XYt (ORCPT <rfc822;w@1wt.eu>);
        Sun, 29 Jan 2017 18:24:49 -0500
Received: from shards.monkeyblade.net ([184.105.139.130]:40760 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751194AbdA2XYf (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 29 Jan 2017 18:24:35 -0500
Date: Sun, 29 Jan 2017 18:24:27 -0500 (EST)
Message-Id: <20170129.182427.1212745842603180686.davem@davemloft.net>
To: colin.king@canonical.com
Cc: Pavel.Belous@aquantia.com, Alexander.Loktionov@aquantia.com,
        Dmitry.Bezrukov@aquantia.com, vomlehn@texas.net,
        netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next-next] net: ethernet: aquantia: return -ETIME in
 macro AQ_HW_WAIT_FOR
From: David Miller <davem@davemloft.net>
In-Reply-To: <20170127150646.19181-1-colin.king@canonical.com>
References: <20170127150646.19181-1-colin.king@canonical.com>
X-Mailer: Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 29 Jan 2017 14:25:26 -0800 (PST)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Colin King <colin.king@canonical.com>
Date: Fri, 27 Jan 2017 15:06:46 +0000

> From: Colin Ian King <colin.king@canonical.com>
> 
> The macro is returning ETIME which means various checks to see if
> the returned err is less than zero never work. I believe a -ETIME
> should be returned instead.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Applied.