From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752500AbdA3HoH (ORCPT ); Mon, 30 Jan 2017 02:44:07 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:41379 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752128AbdA3HoG (ORCPT ); Mon, 30 Jan 2017 02:44:06 -0500 From: maxime.ripard@free-electrons.com Date: Mon, 30 Jan 2017 08:44:04 +0100 To: Icenowy Zheng Cc: Srinivas Kandagatla , Chen-Yu Tsai , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH v2 1/2] nvmem: sunxi-sid: add support for H3 and A64's SID controller Message-ID: <20170130074404.d7mi6h4kviornr5s@lukather> References: <20170129015641.54281-1-icenowy@aosc.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="leyuzbntcohtfq2k" Content-Disposition: inline In-Reply-To: <20170129015641.54281-1-icenowy@aosc.xyz> eFrom: Maxime Ripard User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --leyuzbntcohtfq2k Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jan 29, 2017 at 09:56:40AM +0800, Icenowy Zheng wrote: > H3 and A64 SoCs have a bigger SID controller, which has its direct read > address at 0x200 position in the SID block, not 0x0. >=20 > Also, H3 SID controller has some silicon bug that makes the direct read > value wrong at first, add code to workaround the bug. (This bug has > already been fixed on A64 and later SoCs) >=20 > Signed-off-by: Icenowy Zheng Please split that into several patches. One to allow to set the size through the structure, one to support the A64, and one to support the H3. Thanks, Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --leyuzbntcohtfq2k Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCAAGBQJYju7EAAoJEBx+YmzsjxAgLiwP/0J9F3h+4nZA24PP1qo4rxA4 oVuS4QgyJpUsWc/WPMPl3ysKJ9kewgEGWa74VKFXSEnkejVin4SvfOtT83N+rrvb L7DuKJ10pHi2MOpvf9xHAPJvuZyXnE1LPuI477U/03EvAvoEx7hQu7NzGAOXdjEg gLFr5jcXndpJdLVJekFpuIWxVRkXu438bcc4XJw7GOSnBjOGfHYaR36HA8mXXgOl QvM93MNVUMQqXODIVBw1nz2VyS5mDrpIrehQVRj9W+8X3UPQtiXONiRMR9rdlszO uTFq7GEJQZC9c5QgLRlWIlTKpy89zOGvTDib3VMYEgFY9UNMNhMdEvT/wp+pXNSA fvTOSm3DQrEil234I6t+jYIWDVQdCWZ3c/X6CUlc7OSbbg1OgjP7Q0mw4V2ksnwQ k2Tm2t5GC3ZJJWWwEkhYIZ/RGseg/Qaq6X8rZV7JEwRHBGO2V4Ag+WZmllyMXY+K GwRak3RmGR8Qv5clImUIZC4CDUKS9XKehmrII42xK49NdKJcwRk8cX/u8naDUBxi eDCfGqWGP1FZRIykMRq/gZTe+ObyO0ZvroN9jempmhnHjBvlUsonz5vGUgbbSMPT iG4fa8EM/xEg8HDDvVPLiQCef9xeEqLtp+UD3crrSmbsLKb4k1oyinNp8oYTmS/K ZBedNt284RjcruncYXoi =Om54 -----END PGP SIGNATURE----- --leyuzbntcohtfq2k--