From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752786AbdA3Ll2 (ORCPT ); Mon, 30 Jan 2017 06:41:28 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:60005 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750984AbdA3LlU (ORCPT ); Mon, 30 Jan 2017 06:41:20 -0500 Date: Mon, 30 Jan 2017 17:11:05 +0530 From: Gautham R Shenoy To: Michael Ellerman Cc: "Rafael J. Wysocki" , "Gautham R. Shenoy" , Benjamin Herrenschmidt , Paul Mackerras , "Rafael J. Wysocki" , Daniel Lezcano , Michael Neuling , Vaidyanathan Srinivasan , "Shreyas B. Prabhu" , Shilpasri G Bhat , Stewart Smith , Balbir Singh , "Oliver O'Halloran" , Rob Herring , linuxppc-dev , Linux Kernel Mailing List , Linux PM , "devicetree@vger.kernel.org" , Mark Rutland Subject: Re: [PATCH v6 3/5] cpuidle:powernv: Add helper function to populate powernv idle states. Reply-To: ego@linux.vnet.ibm.com References: <1485333389-5752-1-git-send-email-ego@linux.vnet.ibm.com> <1485333389-5752-4-git-send-email-ego@linux.vnet.ibm.com> <871svlxl7w.fsf@concordia.ellerman.id.au> <87efzkx0dd.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87efzkx0dd.fsf@concordia.ellerman.id.au> User-Agent: Mutt/1.5.23 (2014-03-12) X-TM-AS-GCONF: 00 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 17013011-0028-0000-0000-000006E95C7F X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00006524; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000201; SDB=6.00814704; UDB=6.00397656; IPR=6.00592146; BA=6.00005099; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00014104; XFM=3.00000011; UTC=2017-01-30 11:41:18 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17013011-0029-0000-0000-000033244874 Message-Id: <20170130114105.GA4290@in.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-01-30_08:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1612050000 definitions=main-1701300118 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 30, 2017 at 10:17:50PM +1100, Michael Ellerman wrote: > "Rafael J. Wysocki" writes: > > > On Mon, Jan 30, 2017 at 4:47 AM, Michael Ellerman wrote: > >> "Gautham R. Shenoy" writes: > >> > >>> From: "Gautham R. Shenoy" > >>> > >>> In the current code for powernv_add_idle_states, there is a lot of code > >>> duplication while initializing an idle state in powernv_states table. > >>> > >>> Add an inline helper function to populate the powernv_states[] table > >>> for a given idle state. Invoke this for populating the "Nap", > >>> "Fastsleep" and the stop states in powernv_add_idle_states. > >>> > >>> Acked-by: Balbir Singh > >>> Signed-off-by: Gautham R. Shenoy > >>> --- > >>> drivers/cpuidle/cpuidle-powernv.c | 89 +++++++++++++++++++++++---------------- > >>> include/linux/cpuidle.h | 1 + > >> > >> I was going to merge this, but I see you've touched cpuidle.h, so I feel > >> like I should get an ACK from the cpuidle folks. > >> > >> It's a fairly uncontroversial change, but it's their API. > > > > OK, please add an ACK from me to it then. > > Thanks. Thanks Rafael and Michal. > > cheers > -- Thanks and Regards gautham.