From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754161AbdA3TTc (ORCPT ); Mon, 30 Jan 2017 14:19:32 -0500 Received: from smtprelay0141.hostedemail.com ([216.40.44.141]:57099 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754009AbdA3TTa (ORCPT ); Mon, 30 Jan 2017 14:19:30 -0500 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:3138:3139:3140:3141:3142:3352:3622:3865:3867:3868:3871:3872:3873:3874:4250:4605:5007:6261:7875:8603:10004:10400:10848:10967:11026:11232:11658:11914:12043:12438:12740:12760:12895:13069:13311:13357:13439:14096:14097:14181:14659:14721:21080:30051:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:3,LUA_SUMMARY:none X-HE-Tag: knee89_8178f701c0d08 X-Filterd-Recvd-Size: 1956 Date: Mon, 30 Jan 2017 14:18:08 -0500 From: Steven Rostedt To: Peter Zijlstra Cc: Alexander Potapenko , Andrey Ryabinin , Dmitry Vyukov , LKML Subject: Re: [PATCH] kasan: Respect /proc/sys/kernel/traceoff_on_warning Message-ID: <20170130141808.408c5241@gandalf.local.home> In-Reply-To: <20170125143532.GR6515@twins.programming.kicks-ass.net> References: <20170125142524.GQ6515@twins.programming.kicks-ass.net> <20170125142852.GE6536@twins.programming.kicks-ass.net> <20170125143532.GR6515@twins.programming.kicks-ass.net> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 25 Jan 2017 15:35:32 +0100 Peter Zijlstra wrote: > On Wed, Jan 25, 2017 at 03:32:11PM +0100, Alexander Potapenko wrote: > > > > @@ -300,6 +301,8 @@ void kasan_report(unsigned long addr, size_t size, > > > if (likely(!kasan_report_enabled())) > > > return; > > > > > > + disable_trace_on_warning(); > > > + > > Who is going to enable tracing back after we're done? > > The user.. Yep, # echo 1 > /sys/kernel/debug/tracing/tracing_on Re-enables tracing. -- Steve > > > Note that KASAN errors are not fatal, and the first one may possibly > > occur quite early. > > WARN*() isn't fatal either, and it does the same thing. Note that > traceoff_on_warning is default disabled. You have to explicitly request > this.