From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932455AbdA3Pxi (ORCPT ); Mon, 30 Jan 2017 10:53:38 -0500 Received: from mx2.suse.de ([195.135.220.15]:40577 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751467AbdA3PO0 (ORCPT ); Mon, 30 Jan 2017 10:14:26 -0500 Date: Mon, 30 Jan 2017 16:13:32 +0100 From: Michal Hocko To: Yisheng Xie , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, n-horiguchi@ah.jp.nec.com, minchan@kernel.org, vbabka@suse.cz, guohanjun@huawei.com, qiuxishi@huawei.com Subject: Re: [PATCH v4 1/2] mm/migration: make isolate_movable_page always defined Message-ID: <20170130151331.GA5311@dhcp22.suse.cz> References: <1485356738-4831-1-git-send-email-ysxie@foxmail.com> <1485356738-4831-2-git-send-email-ysxie@foxmail.com> <20170126091833.GC6590@dhcp22.suse.cz> <588F54E8.5040303@foxmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <588F54E8.5040303@foxmail.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 30-01-17 22:59:52, Yisheng Xie wrote: > Hi， Michal， > Sorry for late reply. > > On 01/26/2017 05:18 PM, Michal Hocko wrote: > > On Wed 25-01-17 23:05:37, ysxie@foxmail.com wrote: > >> From: Yisheng Xie > >> > >> Define isolate_movable_page as a static inline function when > >> CONFIG_MIGRATION is not enable. It should return false > >> here which means failed to isolate movable pages. > >> > >> This patch do not have any functional change but prepare for > >> later patch. > > I think it would make more sense to make isolate_movable_page return int > > and have the same semantic as __isolate_lru_page. This would be a better > > preparatory patch for the later work. > Yes, I think you are right, it is better to make isolate_movable_page return int > just as what isolate_lru_page do, to make a better code style. > > It seems Andrew had already merged the fixed patch from Arnd Bergmann, > Maybe I can rewrite it in a later patch if it is suitable :) I guess Andrew can just drop the current series with the folow up fixes and wait for your newer version. -- Michal Hocko SUSE Labs