From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753900AbdA3RjB (ORCPT ); Mon, 30 Jan 2017 12:39:01 -0500 Received: from mga02.intel.com ([134.134.136.20]:52406 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751406AbdA3RjA (ORCPT ); Mon, 30 Jan 2017 12:39:00 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,312,1477983600"; d="scan'208";a="53811946" Date: Tue, 31 Jan 2017 01:38:34 +0800 From: kbuild test robot To: Heikki Krogerus Cc: kbuild-all@01.org, Greg KH , Guenter Roeck , Oliver Neukum , Mika Westerberg , Felipe Balbi , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: [PATCH] usb: typec: fix ptr_ret.cocci warnings Message-ID: <20170130173832.GA5608@lkp-ib03.lkp.intel.com> References: <201701310115.zBz8Tqzh%fengguang.wu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170130124924.47634-4-heikki.krogerus@linux.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: fengguang.wu@intel.com X-SA-Exim-Scanned: No (on bee); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org drivers/usb/typec/typec.c:1249:1-3: WARNING: PTR_ERR_OR_ZERO can be used Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Generated by: scripts/coccinelle/api/ptr_ret.cocci CC: Heikki Krogerus Signed-off-by: Fengguang Wu --- typec.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) --- a/drivers/usb/typec/typec.c +++ b/drivers/usb/typec/typec.c @@ -1246,9 +1246,7 @@ EXPORT_SYMBOL_GPL(typec_unregister_port) static int __init typec_init(void) { typec_class = class_create(THIS_MODULE, "typec"); - if (IS_ERR(typec_class)) - return PTR_ERR(typec_class); - return 0; + return PTR_ERR_OR_ZERO(typec_class); } subsys_initcall(typec_init);