From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751305AbdAaQN1 (ORCPT ); Tue, 31 Jan 2017 11:13:27 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:34818 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751039AbdAaQNT (ORCPT ); Tue, 31 Jan 2017 11:13:19 -0500 Date: Tue, 31 Jan 2017 11:11:52 -0500 (EST) Message-Id: <20170131.111152.1190518672369292507.davem@davemloft.net> To: hch@lst.de Cc: axboe@kernel.dk, linux-block@vger.kernel.org, linux-scsi@vger.kernel.org, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 09/10] ide: don't abuse cmd_type From: David Miller In-Reply-To: <1485878251-6107-10-git-send-email-hch@lst.de> References: <1485878251-6107-1-git-send-email-hch@lst.de> <1485878251-6107-10-git-send-email-hch@lst.de> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 31 Jan 2017 07:12:53 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Christoph Hellwig Date: Tue, 31 Jan 2017 16:57:30 +0100 > Currently the legacy ide driver defines several request types of it's own, > which is in the way of removing that field entirely. > > Instead add a type field to struct ide_request and use that to distinguish > the different types of IDE-internal requests. > > It's a bit of a mess, but so is the surrounding code.. > > Signed-off-by: Christoph Hellwig Acked-by: David S. Miller