From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750836AbdAaH5Q (ORCPT ); Tue, 31 Jan 2017 02:57:16 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:56150 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750758AbdAaH5I (ORCPT ); Tue, 31 Jan 2017 02:57:08 -0500 Date: Tue, 31 Jan 2017 13:25:37 +0530 From: "Naveen N. Rao" To: Michael Ellerman Cc: Anju T Sudhakar , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, ananth@in.ibm.com, paulus@samba.org, srikar@linux.vnet.ibm.com, benh@kernel.crashing.org, mahesh@linux.vnet.ibm.com, mhiramat@kernel.org Subject: Re: [PATCH V3 3/4] arch/powerpc: Implement Optprobes References: <1482153507-17350-1-git-send-email-anju@linux.vnet.ibm.com> <1482153507-17350-2-git-send-email-anju@linux.vnet.ibm.com> <878tpswa6g.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <878tpswa6g.fsf@concordia.ellerman.id.au> User-Agent: Mutt/1.6.2 (2016-07-01) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 17013107-0004-0000-0000-000001DB6C8C X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17013107-0005-0000-0000-0000099597F9 Message-Id: <20170131075536.GA3824@naverao1-tp.localdomain> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-01-31_03:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1612050000 definitions=main-1701310072 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017/01/31 07:43AM, Michael Ellerman wrote: > Anju T Sudhakar writes: > > > Detour buffer contains instructions to create an in memory pt_regs. > > After the execution of the pre-handler, a call is made for instruction emulation. > > The NIP is determined in advanced through dummy instruction emulation and a branch > > instruction is created to the NIP at the end of the trampoline. > > > > Instruction slot for detour buffer is allocated from the reserved area. > > For the time being, 64KB is reserved in memory for this purpose. > > > > Instructions which can be emulated using analyse_instr() are suppliants > > for optimization. Before optimization ensure that the address range > > between the detour buffer allocated and the instruction being probed > > is within ± 32MB. > > > > Signed-off-by: Anju T Sudhakar > > Signed-off-by: Naveen N. Rao > > --- > > .../features/debug/optprobes/arch-support.txt | 2 +- > > arch/powerpc/Kconfig | 1 + > > arch/powerpc/include/asm/kprobes.h | 24 +- > > arch/powerpc/include/asm/sstep.h | 1 + > > arch/powerpc/kernel/Makefile | 1 + > > arch/powerpc/kernel/optprobes.c | 331 +++++++++++++++++++++ > > arch/powerpc/kernel/optprobes_head.S | 135 +++++++++ > > arch/powerpc/lib/sstep.c | 21 ++ > > 8 files changed, 514 insertions(+), 2 deletions(-) > > create mode 100644 arch/powerpc/kernel/optprobes.c > > create mode 100644 arch/powerpc/kernel/optprobes_head.S > > This breaks the pseries_defconfig (at least) build: > > In file included from ../include/linux/kprobes.h:45:0, > from ../arch/powerpc/kernel/optprobes.c:12: > ../arch/powerpc/kernel/optprobes.c: In function ‘arch_prepare_optimized_kprobe’: > ../arch/powerpc/include/asm/kprobes.h:79:16: error: ‘MODULE_NAME_LEN’ undeclared (first use in this function) > char dot_name[MODULE_NAME_LEN + 1 + KSYM_NAME_LEN]; \ > ^ > ../arch/powerpc/kernel/optprobes.c:230:2: note: in expansion of macro ‘kprobe_lookup_name’ > kprobe_lookup_name("optimized_callback", op_callback_addr); > ^~~~~~~~~~~~~~~~~~ > ../arch/powerpc/include/asm/kprobes.h:79:16: note: each undeclared identifier is reported only once for each function it appears in > char dot_name[MODULE_NAME_LEN + 1 + KSYM_NAME_LEN]; \ > ^ > ../arch/powerpc/kernel/optprobes.c:230:2: note: in expansion of macro ‘kprobe_lookup_name’ > kprobe_lookup_name("optimized_callback", op_callback_addr); > ^~~~~~~~~~~~~~~~~~ > ../arch/powerpc/include/asm/kprobes.h:82:14: error: assignment discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers] > if ((modsym = strchr(name, ':')) != NULL) { \ > ^ > ../arch/powerpc/kernel/optprobes.c:230:2: note: in expansion of macro ‘kprobe_lookup_name’ > kprobe_lookup_name("optimized_callback", op_callback_addr); > ^~~~~~~~~~~~~~~~~~ > ../arch/powerpc/include/asm/kprobes.h:79:7: error: unused variable ‘dot_name’ [-Werror=unused-variable] > char dot_name[MODULE_NAME_LEN + 1 + KSYM_NAME_LEN]; \ > ^ > ../arch/powerpc/kernel/optprobes.c:230:2: note: in expansion of macro ‘kprobe_lookup_name’ > kprobe_lookup_name("optimized_callback", op_callback_addr); > ^~~~~~~~~~~~~~~~~~ > ../arch/powerpc/include/asm/kprobes.h:82:14: error: assignment discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers] > if ((modsym = strchr(name, ':')) != NULL) { \ > ^ > ../arch/powerpc/kernel/optprobes.c:231:2: note: in expansion of macro ‘kprobe_lookup_name’ > kprobe_lookup_name("emulate_step", emulate_step_addr); > ^~~~~~~~~~~~~~~~~~ > ../arch/powerpc/include/asm/kprobes.h:79:7: error: unused variable ‘dot_name’ [-Werror=unused-variable] > char dot_name[MODULE_NAME_LEN + 1 + KSYM_NAME_LEN]; \ > ^ > ../arch/powerpc/kernel/optprobes.c:231:2: note: in expansion of macro ‘kprobe_lookup_name’ > kprobe_lookup_name("emulate_step", emulate_step_addr); > ^~~~~~~~~~~~~~~~~~ > cc1: all warnings being treated as errors > make[2]: *** [arch/powerpc/kernel/optprobes.o] Error 1 > make[2]: *** Waiting for unfinished jobs.... > make[1]: *** [arch/powerpc/kernel] Error 2 > make[1]: *** Waiting for unfinished jobs.... > make: *** [sub-make] Error 2 > > > This may not be your bug, but your patch exposes it unfortunately. Sorry for the trouble, we should have caught this. - Naveen