From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751889AbdAaMYI (ORCPT ); Tue, 31 Jan 2017 07:24:08 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:44258 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751821AbdAaMXq (ORCPT ); Tue, 31 Jan 2017 07:23:46 -0500 From: Colin King To: "James E . J . Bottomley" , "Martin K . Petersen" , Jens Axboe , Hannes Reinecke , Shaun Tancheff , Johannes Thumshirn , linux-scsi@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] scsi_dh_emc: fix uninitialized return value ret Date: Tue, 31 Jan 2017 12:22:05 +0000 Message-Id: <20170131122205.24482-1-colin.king@canonical.com> X-Mailer: git-send-email 2.10.2 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin Ian King ret is uninitialized on a successful execution of clarrion_std_inquiry and a garbage return value is being returted. Fix this by setting ret to zero on the success exit path. Found by CoverityScan, CID#1398889 ("Uninitialized scaler variable") Fixes: b78205c93297b8219 ("scsi_dh_emc: switch to scsi_execute_req_flags()") Signed-off-by: Colin Ian King --- drivers/scsi/device_handler/scsi_dh_emc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/device_handler/scsi_dh_emc.c b/drivers/scsi/device_handler/scsi_dh_emc.c index 4a7679f..6647da2 100644 --- a/drivers/scsi/device_handler/scsi_dh_emc.c +++ b/drivers/scsi/device_handler/scsi_dh_emc.c @@ -376,6 +376,7 @@ static int clariion_std_inquiry(struct scsi_device *sdev, sdev_printk(KERN_INFO, sdev, "%s: detected Clariion %s, flags %x\n", CLARIION_NAME, sp_model, csdev->flags); + err = 0; out: return err; } -- 2.10.2